From owner-freebsd-ports@FreeBSD.ORG  Tue Mar 24 10:39:11 2015
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: ports@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 95EEAE34;
 Tue, 24 Mar 2015 10:39:11 +0000 (UTC)
Received: from smtprelay06.ispgateway.de (smtprelay06.ispgateway.de
 [80.67.18.29])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 54E7886;
 Tue, 24 Mar 2015 10:39:11 +0000 (UTC)
Received: from [80.67.16.118] (helo=webmailfront01.ispgateway.de)
 by smtprelay06.ispgateway.de with esmtpsa (TLSv1:DHE-RSA-AES256-SHA:256)
 (Exim 4.84) (envelope-from <mva@freebsd.org>)
 id 1YaM8W-0003c0-Ld; Tue, 24 Mar 2015 11:32:40 +0100
Received: from his1.his.de (his1.his.de [192.124.237.237]) by webmail.df.eu
 (Horde Framework) with HTTP; Tue, 24 Mar 2015 11:32:40 +0100
Date: Tue, 24 Mar 2015 11:32:40 +0100
Message-ID: <20150324113240.Horde._MOpnfwGcxQa7v8pi_ozUQ2@webmail.df.eu>
From: Marcus von Appen <mva@freebsd.org>
To: Julian Elischer <julian@freebsd.org>, ports@freebsd.org
Subject: Re: patch to bsd.ports.mk to support out-of-tree patches.
References: <5510F71B.7030900@freebsd.org>
In-Reply-To: <5510F71B.7030900@freebsd.org>
Reply-to: mva@freebsd.org
User-Agent: Internet Messaging Program (IMP) H5 (6.0.4)
Content-Type: text/plain; charset=UTF-8; format=flowed; DelSp=Yes
MIME-Version: 1.0
Content-Disposition: inline
X-Df-Sender: ZnJlZWJzZEBzeXNmYXVsdC5vcmc=
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-ports>,
 <mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports/>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
 <mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 24 Mar 2015 10:39:11 -0000

Julian Elischer <julian@freebsd.org>:

[...]
>          esac | ${PATCH} ${PATCH_DIST_ARGS} `patch_dist_strip $$i` ; \
>      done )
>  .endif
> +.if defined(EXTRA_PATCH_TREE)
[...]
> +.endif
>  .if defined(EXTRA_PATCHES)
>      @set -e ; \
>      for i in ${EXTRA_PATCHES}; do \
>
>
> ============

Nice. I'd however change the patch behaviour to the following:

- patch-* from FreeBSD
- EXTRA_PATCHES from FreeBSD
- local patches

Your patch looks like it appleis the out-of-tree patches prior
to any EXTRA_PATCHES defined by the port itself. This should not be
the case, in my opinion. Locally managed patches should always come
last to ensure that all FreeBSD/maintainer-specific bits have been
applied and the local changes are just added on top of those.

Cheers
Marcus