From owner-svn-ports-all@freebsd.org Wed Mar 28 15:50:09 2018 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D20ADF6984F; Wed, 28 Mar 2018 15:50:09 +0000 (UTC) (envelope-from bacon4000@gmail.com) Received: from mail-it0-x229.google.com (mail-it0-x229.google.com [IPv6:2607:f8b0:4001:c0b::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 05D4772AB1; Wed, 28 Mar 2018 15:50:08 +0000 (UTC) (envelope-from bacon4000@gmail.com) Received: by mail-it0-x229.google.com with SMTP id 142-v6so4345587itl.5; Wed, 28 Mar 2018 08:50:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=ADTE4bVBzwMYEYnSyYuzxCyf+DfwleBHs/N0RzZOMM0=; b=bZF4UUdp14krWxSESW2aRBDUVNdYI0I8XYp7tB3zG5eD+Sgef4iKKkfUOUxM6RZo5W nwUXnSjSeOU+HGiTwRMmOqIMDKBQ56q5FowjbhdgPB3Uw8gJO8Zpl4kzVIBxP6h1XXGj VFgBOeiRo+wyPmPFsvZEe1+US0Jc6klrdol68dqOUSyVonDgBG2z33cMme0+yVYXqJ0i ZfH8tVFysQsDHHfdgsiTuuD32mR6cSlEdQ4mf/MsCuEF4GqimFp0r4PUsbr1jewXOEGN q8TbYFmsRNtqhGvisapggP9D25MAy4px9bMjbJASn0xSDTq+vr5i72ux2KjXK7Z+jExg pU2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=ADTE4bVBzwMYEYnSyYuzxCyf+DfwleBHs/N0RzZOMM0=; b=gE4v50UKdHhYAjWWOOSm1HHLSDhslRNWycyJDRu81e4N+29Vqe4LshGpheRDaN+aKI 7zyPoB5EOmIpUpZf7xDEq8AuNASez6Ta0MtlqAJY8mUDZlpJgvIlbdzXOHgGoPlYyT4s wVDF+9RyAHgSjEBFZDgw2JoOJS852DXcz/p2IUS5Vcjf665sOGiRdNR0V7eWYOqfdVxW pAd9mlTw9MoZkWFhzc4P5W125UFCGqUdUgPzV+v3FhFwSOvuehYQm/xe8zAREkA0xZzN FzRsgzBczaDn1ehUhAg6e8SlEJ3tYAPvwb2wZPkFmp7MueULRHe+YgpEmPHEknDg/bou vw1g== X-Gm-Message-State: ALQs6tDGs9biOX1tA81qnBxb1qqSBoZHFN40e6dvAKxfucUDfWs0lEgf lmsrnbWOWg/a09ml3t6vEtf14kIc X-Google-Smtp-Source: AIpwx4+Szm55566037zW1/FvCmlPxKIzxpR3uXbKczvH4S3LMFX7L7JUEXkJweN5iChWqPKaIIPcqw== X-Received: by 2002:a24:3dcc:: with SMTP id n195-v6mr2855389itn.25.1522252208042; Wed, 28 Mar 2018 08:50:08 -0700 (PDT) Received: from imacbsd.acadix.biz ([2605:a000:bc48:7d00:216:cbff:feb9:145]) by smtp.gmail.com with ESMTPSA id w71sm53627iow.87.2018.03.28.08.50.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 28 Mar 2018 08:50:07 -0700 (PDT) Subject: Re: svn commit: r465808 - in head/biology: . bamtools bamtools/files To: Mathieu Arnold , "Jason W. Bacon" Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org References: <201803281326.w2SDQVl6065909@repo.freebsd.org> <20180328134346.lw4s67embg2n4gk5@ogg.in.absolight.net> From: Jason Bacon Message-ID: <58a2ebc1-c58b-e58e-93f8-0583e7ebfe8b@gmail.com> Date: Wed, 28 Mar 2018 10:50:06 -0500 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180328134346.lw4s67embg2n4gk5@ogg.in.absolight.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Mar 2018 15:50:10 -0000 On 03/28/18 08:43, Mathieu Arnold wrote: > On Wed, Mar 28, 2018 at 01:26:31PM +0000, Jason W. Bacon wrote: >> +LIB_DEPENDS+= libjsoncpp.so:devel/jsoncpp >> +CMAKE_ON+= BUILD_SHARED_LIBS > Why += ? > Old habit.  I came under the impression long ago that using CONFIGURE_ARGS= instead of CONFIGURE_ARGS+= would clobber args injected by the ports system, and I transferred the same habit to cmake.  This doesn't appear to be true anymore, if it ever was. Time to break the habit.  Thanks for the heads-up. -- Earth is a beta site.