From owner-cvs-src-old@FreeBSD.ORG  Sun Dec 26 13:06:04 2010
Return-Path: <owner-cvs-src-old@FreeBSD.ORG>
Delivered-To: cvs-src-old@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 1755C1065674
	for <cvs-src-old@freebsd.org>; Sun, 26 Dec 2010 13:06:04 +0000 (UTC)
	(envelope-from cperciva@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id 061A38FC1F
	for <cvs-src-old@freebsd.org>; Sun, 26 Dec 2010 13:06:04 +0000 (UTC)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.4/8.14.4) with ESMTP id oBQD634U003091
	for <cvs-src-old@freebsd.org>; Sun, 26 Dec 2010 13:06:03 GMT
	(envelope-from cperciva@repoman.freebsd.org)
Received: (from svn2cvs@localhost)
	by repoman.freebsd.org (8.14.4/8.14.4/Submit) id oBQD63tZ003090
	for cvs-src-old@freebsd.org; Sun, 26 Dec 2010 13:06:03 GMT
	(envelope-from cperciva@repoman.freebsd.org)
Message-Id: <201012261306.oBQD63tZ003090@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: svn2cvs set sender to
	cperciva@repoman.freebsd.org using -f
From: Colin Percival <cperciva@FreeBSD.org>
Date: Sun, 26 Dec 2010 13:05:43 +0000 (UTC)
To: cvs-src-old@freebsd.org
X-FreeBSD-CVS-Branch: HEAD
Subject: cvs commit: src/sys/i386/xen pmap.c
X-BeenThere: cvs-src-old@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: **OBSOLETE** CVS commit messages for the src tree
	<cvs-src-old.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src-old>,
	<mailto:cvs-src-old-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src-old>
List-Post: <mailto:cvs-src-old@freebsd.org>
List-Help: <mailto:cvs-src-old-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src-old>,
	<mailto:cvs-src-old-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 26 Dec 2010 13:06:04 -0000

cperciva    2010-12-26 13:05:43 UTC

  FreeBSD src repository

  Modified files:
    sys/i386/xen         pmap.c 
  Log:
  SVN rev 216703 on 2010-12-26 13:05:43Z by cperciva
  
  Lock the vm page queue mutex in pmap_pte_release around the call
  to PMAP_SET_VA; this fixes a mutex-not-held panic when a process
  which called mlock(2) exits, and parallels a change made in
  pmap_pte 10 months ago (svn r204160).
  
  Note: The locking in this code is utterly broken.  We should not
  be using the VM page queue mutex to protect the queue of pending
  Xen page mapping hypervisor calls.  Even if it made sense to do
  so, this commit and r204160 introduce LORs between the vm page
  queue mutex and PMAP2mutex.
  
  (However, a possible deadlock is better than a guaranteed panic,
  and this change will hopefully make life easier for whoever fixes
  the Xen pmap locking in the future.)
  
  PR:             kern/140313
  MFC after:      3 days
  
  Revision  Changes    Path
  1.55      +2 -0      src/sys/i386/xen/pmap.c