From owner-svn-ports-all@FreeBSD.ORG  Thu Nov 14 17:24:25 2013
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 0A1D66B9;
 Thu, 14 Nov 2013 17:24:25 +0000 (UTC)
Received: from prod2.absolight.net (mx3.absolight.net
 [IPv6:2a01:678:2:100::25])
 (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id C040C2D66;
 Thu, 14 Nov 2013 17:24:24 +0000 (UTC)
Received: from prod2.absolight.net (localhost [127.0.0.1])
 by prod2.absolight.net (Postfix) with ESMTP id 5E2E9BDC77;
 Thu, 14 Nov 2013 18:24:23 +0100 (CET)
Received: from gw.in.absolight.net (gw-ecl.in.absolight.net [79.143.241.69])
 (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
 (Client CN "gw.in.absolight.net",
 Issuer "CA Cert Signing Authority" (not verified))
 by prod2.absolight.net (Postfix) with ESMTPSA id 4B5B3BDC72;
 Thu, 14 Nov 2013 18:24:23 +0100 (CET)
Received: from ogg.in.absolight.net (ogg.in.absolight.net [79.143.241.239])
 by gw.in.absolight.net (Postfix) with ESMTP id A5F526127;
 Thu, 14 Nov 2013 18:24:22 +0100 (CET)
Received: from localhost (localhost [127.0.0.1])
 by ogg.in.absolight.net (Postfix) with ESMTP id 5782B645C73D;
 Thu, 14 Nov 2013 18:24:22 +0100 (CET)
Date: Thu, 14 Nov 2013 18:24:22 +0100
From: Mathieu Arnold <mat@FreeBSD.org>
To: Dirk Meyer <dinoex@FreeBSD.org>, ports-committers@freebsd.org,
 svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject: Re: svn commit: r333776 - head/graphics/tiff
Message-ID: <6893661BEC7FF4514A54FFF2@ogg.in.absolight.net>
In-Reply-To: <201311141714.rAEHEYPK010996@svn.freebsd.org>
References: <201311141714.rAEHEYPK010996@svn.freebsd.org>
X-Mailer: Mulberry/4.0.8 (Mac OS X)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.16
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 14 Nov 2013 17:24:25 -0000

+--On 14 novembre 2013 17:14:34 +0000 Dirk Meyer <dinoex@FreeBSD.org> wrote:
| +OPTIONS_DEFINE=	X11
| +OPTIONS_DEFAULT=X11
| +
| +.include <bsd.port.options.mk>
| +
| +.if ${PORT_OPTIONS:MX11}
| +USE_XORG=	sm ice xmu xi x11
| +USE_GL=		glut glu gl
| +PLIST_SUB+=	WITH_X11=""
| +.else
| +CONFIGURE_ARGS+=	--without-x --without-libgl
| +PLIST_SUB+=	WITH_X11="@comment "
| +.endif

This would be better written as :

OPTIONS_DEFINE=	X11
OPTIONS_DEFAULT=X11
OPTIONS_SUB=    yes

X11_USE=        xorg=sm,ice,xmu,xi,x11 gl=glut,glu,gl
X11_CONFIGURE_WITH=     x libgl

.include <bsd.port.options.mk>

Regards,

-- 
Mathieu Arnold