From owner-svn-src-all@freebsd.org Fri Jan 19 12:14:39 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 84119ED2C11; Fri, 19 Jan 2018 12:14:39 +0000 (UTC) (envelope-from hps@selasky.org) Received: from mail.turbocat.net (turbocat.net [88.99.82.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4AE337EB86; Fri, 19 Jan 2018 12:14:39 +0000 (UTC) (envelope-from hps@selasky.org) Received: from hps2016.home.selasky.org (unknown [62.141.128.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.turbocat.net (Postfix) with ESMTPSA id 06A9D26009E; Fri, 19 Jan 2018 13:14:06 +0100 (CET) Subject: Re: svn commit: r327676 - head/sys/compat/linuxkpi/common/include/linux To: rgrimes@freebsd.org, Kristof Provost Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201801071907.w07J7pUF018031@pdx.rh.CN85.dnsmgr.net> From: Hans Petter Selasky Message-ID: Date: Fri, 19 Jan 2018 13:11:14 +0100 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <201801071907.w07J7pUF018031@pdx.rh.CN85.dnsmgr.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Jan 2018 12:14:39 -0000 On 01/07/18 20:07, Rodney W. Grimes wrote: >> -static inline void * >> -kcalloc(size_t n, size_t size, gfp_t flags) >> -{ >> - flags |= __GFP_ZERO; >> - return (mallocarray(n, size, M_KMALLOC, linux_check_m_flags(flags))); >> -} >> - >> static inline void * >> __vmalloc(size_t size, gfp_t flags, int other) >> { >> >> Regards, >> Kristof > > Should probably revert and go through review, > I would at least wait for comments from others. > Hi, I think the current version is fine. The compiler should take care of the inlining so that it doesn't consume additional stack. Else create a review as suggested. BTW: I need mallocarray() MFC'ed to 11-stable, but only the kernel parts. I'm handling the MFC of the LinuxKPI parts. --HPS