From owner-svn-src-all@freebsd.org Thu Apr 18 14:43:56 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A621F15735EC; Thu, 18 Apr 2019 14:43:56 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from smtp-out-no.shaw.ca (smtp-out-no.shaw.ca [64.59.134.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id AE5916A319; Thu, 18 Apr 2019 14:43:55 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from spqr.komquats.com ([70.67.125.17]) by shaw.ca with ESMTPA id H8GPhd7x0ldkPH8GQhAm7m; Thu, 18 Apr 2019 08:43:47 -0600 X-Authority-Analysis: v=2.3 cv=Ko4zJleN c=1 sm=1 tr=0 a=VFtTW3WuZNDh6VkGe7fA3g==:117 a=VFtTW3WuZNDh6VkGe7fA3g==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=IkcTkHD0fZMA:10 a=oexKYjalfGEA:10 a=iKhvJSA4AAAA:8 a=6I5d2MoRAAAA:8 a=iaTFZB6CAAAA:8 a=zxA2vyXaAAAA:8 a=YxBL1-UpAAAA:8 a=Z0HR4rKzYdLA8CT5LLUA:9 a=QEXdDO2ut3YA:10 a=odh9cflL3HIXMm4fY7Wr:22 a=IjZwj45LgO3ly-622nXo:22 a=QWXrQ9iV8q7LKaLQ9lfw:22 a=nK2txNHJmq7TfjpuLlwI:22 a=Ia-lj3WSrqcvXOmTRaiG:22 Received: from [192.168.0.103] (S0106002401cb186f.gv.shawcable.net [70.67.125.17]) by spqr.komquats.com (Postfix) with ESMTPSA id 33A921142; Thu, 18 Apr 2019 07:43:44 -0700 (PDT) Date: Thu, 18 Apr 2019 07:43:43 -0700 User-Agent: K-9 Mail for Android In-Reply-To: <201904181422.x3IEMrux005930@gndrsh.dnsmgr.net> References: <201904181422.x3IEMrux005930@gndrsh.dnsmgr.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: svn commit: r346341 - head/tools/build To: rgrimes@freebsd.org, "Rodney W. Grimes" , Kyle Evans CC: "Rodney W. Grimes" , Cy Schubert , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org From: Cy Schubert Message-ID: <3095E422-7865-4EA5-BF13-6A48CB542AEE@cschubert.com> X-CMAE-Envelope: MS4wfCQHwB/x0RpW3Tdiut7Dyy+VXL72xUQRWCOmJiapH7DOABzMTA2j9hBMIS9JQGAtBtczVz2sAgNeogEex65/3VIgn6JL1NdYYbnk/HZUN+9FFWMTypQk SQaNsYK+494WXIZ/haz705XxtaEz1NcKwpvfcCUSm+069CMWQexssVfLVB/0uK2IgcjypJ124Qhr2tvE5FWq9lQlKTdoGBMH2Fni9OjSFIkt4Hw2FCyv4i6v bv1oCUazn91ycME7B8+rMZvV5rr1eEadNbNLnwVRk8Mdka9mr1eQSyT6CXv90XZ5c7fFKjHcW+O6eAKsHVYw7NdQrlIwILGFsYpTzfC7UTJrvNnsQCuP1EA6 +EQ4ZHSPsbXvAAgBhTeSMQs09DF1ag== X-Rspamd-Queue-Id: AE5916A319 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.98 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.98)[-0.977,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Apr 2019 14:43:56 -0000 On April 18, 2019 7:22:53 AM PDT, "Rodney W=2E Grimes" wrote: >> On Thu, Apr 18, 2019 at 8:46 AM Rodney W=2E Grimes >> wrote: >> > >> > > In message <201904180107=2Ex3I17QDc002945@gndrsh=2Ednsmgr=2Enet>, >"Rodney W=2E >> > > Grimes" >> > > writes: >> > > > > Author: cy >> > > > > Date: Thu Apr 18 01:02:00 2019 >> > > > > New Revision: 346341 >> > > > > URL: https://svnweb=2Efreebsd=2Eorg/changeset/base/346341 >> > > > > >> > > > > Log: >> > > > > As an interim measure until a more permanent solution is >implemented >> > > > > workaround the following error: >> > > > > >> > > > > /usr/src/contrib/elftoolchain/strings/strings=2Ec:198:55: >error: use of >> > > > > undeclared identifier >> > > > > 'FA_OPEN' fa =3D fileargs_init(argc, argv, O_RDONLY, 0, >&rights, FA_OPEN); >> > > > > >> > > > > Reported by: O=2E Hartmann >> > > > > Reported by: Michael Butler >> > > > > Reported by: gjb@ & cy@ (implicit) >> > > > > Reviewed by: emaste@ >> > > > > Noted by: rgrimes@ >> > > > > >> > > > > Modified: >> > > > > head/tools/build/Makefile >> > > > > >> > > > > Modified: head/tools/build/Makefile >> > > > > >=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D >> > > > =3D=3D=3D >> > > > > --- head/tools/build/Makefile Thu Apr 18 00:38:54 2019 =20 > (r34634 >> > > > 0) >> > > > > +++ head/tools/build/Makefile Thu Apr 18 01:02:00 2019 =20 > (r34634 >> > > > 1) >> > > > > @@ -59,9 +59,7 @@ INCS+=3D capsicum_helpers=2Eh >> > > > > INCS+=3D libcasper=2Eh >> > > > > =2Eendif >> > > > > >> > > > > -=2Eif !exists(/usr/include/casper/cap_fileargs=2Eh) >> > > > > CASPERINC+=3D =20 >${SRCTOP}/lib/libcasper/services/cap_fileargs/cap_filea >> > > > rgs=2Eh >> > > > > -=2Eendif >> > > > >> > > > As a further note, we should probably hunt for any thing >> > > > that is explicity looking at /usr/include/=2E=2E=2E in a Makefile= , >> > > > as that is minimally missing a ${DESTDIR} argument=2E >> > > > >> > > > The above may of actually worked if it had been written: >> > > > =2Eif !exists(${DESTDIR}/usr/include/casper/cap_fileargs=2Eh) >> > > > someone may wish to test that=2E >> > > > >> > > > Also a pathname rooted at / without ${DESTDIR} is almost >certainly a mistake=2E >> > > >> > > This is a better solution=2E I tested this in a tree with a >duplicated >> > > environment: Problem solved=2E Before this is committed it should >be >> > > tested on one of the universe machines=2E >> > >> > From what Ed just said this would also be wrong, >> > as well as CASPERINC+=3D above being wrong, if this >> > is being built for the host we should not be using >> > any headers from ${SRCTOP} at all=2E >> > >> > if capfileargs=2Eh does not exist on the host that functionality >> > must not be compiled into the buildtool as the host does not >> > have this feature and attempting to use it from SRCTOP is wrong=2E >> > >>=20 >> Keep in mind that this is bootstrap; it's being built for the host >> system, but it will link against a version of libcasper that's been >> built in an earlier stage with the proper featureset=2E > >Ok, flip flop again, if infact this is linked against a >library that implements the stuff from cap_fileargs=2Eh then >infact the ${DESTDIR} addition so that the build peaks into >the cross build tree is correct, or what ever the equivelent >to DESTDIR is for that ? BUILDDIR? The point is it should >be picking this header up from the object tree, NOT from >the running system=2E Yes, this was my conclusion when working on kerberos and ntp=2E This is al= so true of libraries, else one would need to installworld and buildworld a= gain to get a properly built library/binary=2E=20 IIRC ngie@ fixed a number of these across the tree a couple of years ago= =2E=20 --=20 Pardon the typos and autocorrect, small keyboard in use=2E Cheers, Cy Schubert FreeBSD UNIX: Web: http://www=2EFreeBSD=2Eorg The need of the many outweighs the greed of the few=2E