From owner-svn-src-all@freebsd.org Thu Jun 14 12:10:52 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D6F3A1022A03 for ; Thu, 14 Jun 2018 12:10:52 +0000 (UTC) (envelope-from eadler@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 41F7786F80 for ; Thu, 14 Jun 2018 12:10:52 +0000 (UTC) (envelope-from eadler@freebsd.org) Received: from mail-yw0-f174.google.com (mail-yw0-f174.google.com [209.85.161.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) (Authenticated sender: eadler) by smtp.freebsd.org (Postfix) with ESMTPSA id 0A3B1E6FF for ; Thu, 14 Jun 2018 12:10:52 +0000 (UTC) (envelope-from eadler@freebsd.org) Received: by mail-yw0-f174.google.com with SMTP id p129-v6so2041181ywg.7 for ; Thu, 14 Jun 2018 05:10:52 -0700 (PDT) X-Gm-Message-State: APt69E3BYjODdluOP206bGB1o9Tt+9Dyk67kst0sfQbUIdRS46q5avCT slvo5sT6Xs4fih+nXp9UMebSGKPcyDLD6YR6Z+yMzw== X-Google-Smtp-Source: ADUXVKJE+0xlqy+4UCpy7oObtBoH/Nz1BOZfOGJoOoIscKXamZgy40/nsmhyCkiNj7ePNM1EfEEnkNXeLGJVL37jnCU= X-Received: by 2002:a0d:cf01:: with SMTP id r1-v6mr1137215ywd.162.1528978251638; Thu, 14 Jun 2018 05:10:51 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a25:ef50:0:0:0:0:0 with HTTP; Thu, 14 Jun 2018 05:10:21 -0700 (PDT) In-Reply-To: <9b6b26cf-dac2-f5ab-e694-5d132ff1bdb9@FreeBSD.org> References: <201806130852.w5D8qKd4094584@repo.freebsd.org> <9b6b26cf-dac2-f5ab-e694-5d132ff1bdb9@FreeBSD.org> From: Eitan Adler Date: Thu, 14 Jun 2018 05:10:21 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r335042 - head/usr.bin/top To: Bryan Drewery Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Jun 2018 12:10:53 -0000 On 13 June 2018 at 17:01, Bryan Drewery wrote: > On 6/13/2018 1:52 AM, Eitan Adler wrote: >> Author: eadler >> Date: Wed Jun 13 08:52:19 2018 >> New Revision: 335042 >> URL: https://svnweb.freebsd.org/changeset/base/335042 >> >> Log: >> top(1): add myself to authors >> >> At this point I've mucked enough with top(1) that all bugs should be >> blamed on me rather than William LeFebvre. >> > > Thank you for all of your work here... > > There's not exactly a guideline for this but I don't feel that > non-functional changes qualify as "authors". I actually meant what I wrote in the commit message: at this point it doesn't make sense to blame William. I'll revert the change to top.1 change as I don't care all that much. Personally, I like being liberal with credit though I understand that isn't the project's stance necessarily. > Especially the sorting chosen. I went with alphabetical. Perhaps I missed some rewrite you've done? Though none have > 'Relnotes: yes' so I am assuming they were all non-functional. Some were functional, I've not done a good job of marking them. > I do see some people adding their Copyright on some commits but overall > we haven't done that as a project and I am curious if we should change > in that regard. The rule of them is about 25% of the file, right? -- Eitan Adler Source, Ports, Doc committer Bugmeister, Ports Security teams