From owner-freebsd-hackers@FreeBSD.ORG Wed Dec 31 06:22:16 2003 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2845916A4CE for ; Wed, 31 Dec 2003 06:22:16 -0800 (PST) Received: from mail.pcnet.com (mail.pcnet.com [204.213.232.4]) by mx1.FreeBSD.org (Postfix) with ESMTP id 23C0443D39 for ; Wed, 31 Dec 2003 06:22:15 -0800 (PST) (envelope-from eischen@vigrid.com) Received: from mail.pcnet.com (mail.pcnet.com [204.213.232.4]) by mail.pcnet.com (8.12.10/8.12.1) with ESMTP id hBVEMEiw006587; Wed, 31 Dec 2003 09:22:14 -0500 (EST) Date: Wed, 31 Dec 2003 09:22:14 -0500 (EST) From: Daniel Eischen X-Sender: eischen@pcnet5.pcnet.com To: Marc Olzheim In-Reply-To: <20031231140533.GA56158@stack.nl> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: hackers@freebsd.org Subject: Re: libc_r/uthread/uthread_join.c X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 Dec 2003 14:22:16 -0000 On Wed, 31 Dec 2003, Marc Olzheim wrote: > On Wed, Dec 31, 2003 at 08:47:03AM -0500, Daniel Eischen wrote: > > > Is there a reason why in the case that a thread is not done yet, > > > pthread_join() does not call _thread_kern_sig_undefer() ? > > > [snip] > > > > No, it looks like you found a bug. Committed, thanks! > > Hmm, ok ;-) But then why is _thread_kern_sig_undefer() called within > every if-case, instead of just below the if ? It looked like it was > contructed this way to be able to omit _thread_kern_sig_undefer() in > that specific case... ;-) Look at revision 1.16 of uthread_join. Revision 1.17 removed the _thread_kern_sig_[un]defer()'s and revision 1.18 put them back in but left an undefer. -- Dan Eischen