From owner-svn-src-head@FreeBSD.ORG Tue Oct 9 17:47:51 2012 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 59FA93AC for ; Tue, 9 Oct 2012 17:47:51 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: from mail-pb0-f54.google.com (mail-pb0-f54.google.com [209.85.160.54]) by mx1.freebsd.org (Postfix) with ESMTP id C568D8FC1A for ; Tue, 9 Oct 2012 17:47:50 +0000 (UTC) Received: by mail-pb0-f54.google.com with SMTP id rp8so6086984pbb.13 for ; Tue, 09 Oct 2012 10:47:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type; bh=lIeh5LcE/O/HgiQOyV76aLryNW/EHoDku1QAycSLd9s=; b=YvhhW4Vk8wNkoh/VKOqkwCveAbVeaOoUMKvU6NBUnbDOqtPmkG6NJwP+j598N5jDox MtuIoufwWxwXw7HGoPZEpLT2H0TdpQoBdyRAC3AVrA2B8sPYQBY1pnmTK38XPbIO84xl Edu9rux7tb/WXd1npEWSyhTCa3RcOshig9nTI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :x-gm-message-state; bh=lIeh5LcE/O/HgiQOyV76aLryNW/EHoDku1QAycSLd9s=; b=lX60ZWkH1ACHh/p54FS+uhF8uGmSLWiaGbB0uYRz39tFdbR2AB38qt1HynN2l/RICi TXqrhK8BJDGNsS72jtS5z/Eadhugsg94ZOxmNdslZ4deBgyytcnscD7PI4NvYEp8xy7Q dDo0Cdl4kZ5vEqDP7X4tdcj5KlUkd8+MZDRebgjn+5Kl9XWchBed8ccRgGen616eqlIw IaFwKCXyvSO0S9Uk4Ad4/AUyl16YR2QFtXA60u3atdKXDEFLkr2r+izwiwd5thUImTZ3 gHeP1n2gDXtPC2Gs8Rf48XSMmUI1IthANILiulhBs2lA56AawoSSMkFdErHEhom18QY9 Kz7A== Received: by 10.66.77.40 with SMTP id p8mr54449126paw.78.1349804870329; Tue, 09 Oct 2012 10:47:50 -0700 (PDT) MIME-Version: 1.0 Sender: lists@eitanadler.com Received: by 10.66.161.163 with HTTP; Tue, 9 Oct 2012 10:47:20 -0700 (PDT) In-Reply-To: <507451DE.9060909@freebsd.org> References: <201210091425.q99EPFS6020787@svn.freebsd.org> <507451DE.9060909@freebsd.org> From: Eitan Adler Date: Tue, 9 Oct 2012 13:47:20 -0400 X-Google-Sender-Auth: luk8TWlNzV065ae0uL0Luu8jRX8 Message-ID: Subject: Re: svn commit: r241373 - head/lib/libc/stdlib To: Andrey Chernov Content-Type: text/plain; charset=UTF-8 X-Gm-Message-State: ALoCoQnmgMW26eiLfdihBJL+zz34t+5IIoZ4qjUvaKIGOzmpcMfg4mPo9pCpng3zrESHuXPbZFBc Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Oct 2012 17:47:51 -0000 On 9 October 2012 12:33, Andrey Chernov wrote: > Do you check assembler output for _both_ cases? Yes. > In my testing clang and gcc xor's 'junk' properly in case it have > 'volatile' keyword (as in srandomdev()) and elide it without 'volatile'. volatile is still undefined: see 5.1.2.2.3 and 6.7.2.4 of ISO9899 > IMHO this change should be backed out for srandomdev() and adding > 'volatile' for sranddev() instead. http://blog.eitanadler.com/2012/10/reduced-entropy-in-rand-and-random.html for additional details and actual assembler output. -- Eitan Adler Source & Ports committer X11, Bugbusting teams