Date: Thu, 24 May 2018 14:08:39 +0200 From: =?UTF-8?Q?Fernando_Apestegu=C3=ADa?= <fernando.apesteguia@gmail.com> To: Mathieu Arnold <mat@freebsd.org> Cc: "Tobias C. Berner" <tcberner@freebsd.org>, Tobias Kortkamp <tobik@freebsd.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r470725 - in head/textproc/tkdiff: . files Message-ID: <CAGwOe2Y5p6QgMAcnmseES%2BOwCvmvL0aJ50iBcHeGxxfpyEvOww@mail.gmail.com> In-Reply-To: <20180524105750.tw2vl4v3trg3jhiv@ogg.in.absolight.net> References: <201805232159.w4NLxYrK000782@repo.freebsd.org> <1527143137.2894038.1383018096.245EB176@webmail.messagingengine.com> <20180524065529.rtcmylbz5qtnupnx@atuin.in.mat.cc> <CAOshKtdixfdPFKyWJst%2BaW4cT_uEYmhc6Adpb3xEVFWWYFaL1A@mail.gmail.com> <20180524105750.tw2vl4v3trg3jhiv@ogg.in.absolight.net>
next in thread | previous in thread | raw e-mail | index | archive | help
El jue., 24 may. 2018 12:57, Mathieu Arnold <mat@freebsd.org> escribi=C3=B3= : > On Thu, May 24, 2018 at 12:43:57PM +0200, Tobias C. Berner wrote: > > That was what I suggested initially. > > > > But as you commented on the target used to install the file without als= o > > weighing in on the issue of adding binaries, I assumed it was fine :) > > I cannot see everything, and most of the times, when my focus catches on > a big mistake, like the two targets, it usually means the Makefile has > larger structural problems that needs addressed first, so I do not delve > too much on what goes on. When the Makefile looks saner, and a quick > glance cannot find anything blatantly wrong, I look deeper into things. > But in any way, I am human, and I miss stuff. > I can prepare an alternative with an icons .tgz distribution and work this out with the maintainer. Sounds good? > > mfg Tobias > > > > On 24 May 2018 at 08:55, Mathieu Arnold <mat@freebsd.org> wrote: > > > > > On Thu, May 24, 2018 at 06:25:37AM +0000, Tobias Kortkamp wrote: > > > > 2. print/jabref, misc/mc, editors/openoffice-devel, etc. seem to ha= ve > > > > binary files in files/*.png. Can we add new ones or is it > forbidden > > > now? > > > > It seems weird to have to base64 encode icons and decode them > during > > > the > > > > build. > > > > > > I think it would be better to keep binary files out of the ports tree= . > > > It's probably as easy to drop them in LOCAL/user, either individually > or > > > in an archive. > > > > > > -- > > > Mathieu Arnold > > > > > -- > Mathieu Arnold >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGwOe2Y5p6QgMAcnmseES%2BOwCvmvL0aJ50iBcHeGxxfpyEvOww>