Date: Fri, 22 Aug 2008 21:35:05 -0400 From: Alexander Kabaev <kabaev@gmail.com> To: arch@freebsd.org Cc: kan@freebsd.org Subject: Re: Need a code review Message-ID: <20080822213505.1993beda@kan.dnsalias.net> In-Reply-To: <20080729.161303.709402272.imp@bsdimp.com> References: <20080729.161303.709402272.imp@bsdimp.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Tue, 29 Jul 2008 16:13:03 -0600 (MDT) "M. Warner Losh" <imp@bsdimp.com> wrote: > Greetings, > > The FreeBSD/mips efforts are getting close. We're down to 4 patches > against the main tree, divided up among different programs: cc, > binutils, libpam and the CDDL stuff for zfs. > > http://people.freebsd.org/~gonzo/mips2/binutils.diff > http://people.freebsd.org/~gonzo/mips2/cc.diff > http://people.freebsd.org/~gonzo/mips2/cddl.diff > http://people.freebsd.org/~gonzo/mips2/libpam.diff > > If you have an interest in any of these area, or would like to provide > feedback on the patches, now would be a good time to do so. :-) > > We'd like to commit these patches to the tree by the end of next week, > if at all possible. If you are a maintainer of this software, we'd > especially like to get feedback from you on these patches. If we > don't hear back from you, we'll assume that you are fine with them :-) > > Warner cc.diff part is OK, except that files we copy from vendor intact should be marked as such. Ideally, by putting their pristine versions in /vendor and branching into head/src/contrib/gcc. Some comments in new FreeBSD files still claim they are for NetBSD/mips. +#ifdef HANDLE_PRAGMA_PACK_PUSH_POP +#undef HANDLE_PRAGMA_PACK_PUSH_POP +#endif #define HANDLE_PRAGMA_PACK_PUSH_POP 1 Can this be rewritten as #ifndef HANDLE_PRAGMA_PACK_PUSH_POP #define HANDLE_PRAGMA_PACK_PUSH_POP 1 #endif ? -- Alexander Kabaev [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iD8DBQFIr2lJQ6z1jMm+XZYRAjj4AJ9wl3y3m6hIaGDn7mvE1B3cW6zp6ACdERA4 cyoxTf9gZ7qWJq/+vlx3KSE= =1cSI -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080822213505.1993beda>