From owner-freebsd-current@FreeBSD.ORG  Fri Feb 14 17:51:37 2014
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 9AB8C121;
 Fri, 14 Feb 2014 17:51:37 +0000 (UTC)
Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1])
 (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 6D4C81457;
 Fri, 14 Feb 2014 17:51:37 +0000 (UTC)
Received: from jhbbsd.localnet (unknown [209.249.190.124])
 by bigwig.baldwin.cx (Postfix) with ESMTPSA id 57AA4B9B1;
 Fri, 14 Feb 2014 12:51:36 -0500 (EST)
From: John Baldwin <jhb@freebsd.org>
To: Roger Pau =?iso-8859-1?q?Monn=E9?= <roger.pau@citrix.com>
Subject: Re: [PATCH RFC 10/13] xen: add ACPI bus to xen_nexus when running as
 Dom0
Date: Fri, 14 Feb 2014 12:50:06 -0500
User-Agent: KMail/1.13.5 (FreeBSD/8.4-CBSD-20130906; KDE/4.5.5; amd64; ; )
References: <1387884062-41154-1-git-send-email-roger.pau@citrix.com>
 <2410827.IqfpSAhe3T@ralph.baldwin.cx> <52FDF217.3040005@citrix.com>
In-Reply-To: <52FDF217.3040005@citrix.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Message-Id: <201402141250.06829.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7
 (bigwig.baldwin.cx); Fri, 14 Feb 2014 12:51:36 -0500 (EST)
Cc: julien.grall@citrix.com, freebsd-xen@freebsd.org,
 freebsd-current@freebsd.org, kib@freebsd.org, xen-devel@lists.xenproject.org,
 gibbs@freebsd.org
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
 <freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current/>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
 <mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 14 Feb 2014 17:51:37 -0000

On Friday, February 14, 2014 5:38:15 am Roger Pau Monn=E9 wrote:
> On 08/02/14 22:50, John Baldwin wrote:
> > On Tuesday, December 24, 2013 12:20:59 PM Roger Pau Monne wrote:
> >> Also disable a couple of ACPI devices that are not usable under Dom0.
> >=20
> > Hmm, setting debug.acpi.disabled in this way is a bit hacky.  It might
> > be fine however if there's no way for the user to set it before booting
> > the kernel (as opposed to haing the relevant drivers explicitly disable
> > themselves under Xen which I think would be cleaner, but would also
> > make your patch larger)
>=20
> Thanks for the review, the user can pass parameters to FreeBSD when
> booted as Dom0, I just find it uncomfortable to force the user into
> always setting something on the command line in order to boot.

Can the user set debug.acpi.disabled?  If so, you are overriding their
setting which would be bad.

> What do you mean with "haing the relevant drivers explicitly disable
> themselves under Xen"? Adding a gate on every one of those devices like
> "if (xen_pv_domain()) return (ENXIO);" in the identify/probe routine
> seems even worse.

A check like this in probe() is what I had in mind, though I agree it's
not perfect.

=2D-=20
John Baldwin