From owner-cvs-sys Sun Aug 17 18:24:55 1997 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.5/8.8.5) id SAA09599 for cvs-sys-outgoing; Sun, 17 Aug 1997 18:24:55 -0700 (PDT) Received: from alpo.whistle.com (alpo.whistle.com [207.76.204.38]) by hub.freebsd.org (8.8.5/8.8.5) with ESMTP id SAA09594; Sun, 17 Aug 1997 18:24:50 -0700 (PDT) Received: (from daemon@localhost) by alpo.whistle.com (8.8.5/8.8.5) id SAA26482; Sun, 17 Aug 1997 18:18:33 -0700 (PDT) Received: from current1.whistle.com(207.76.205.22) via SMTP by alpo.whistle.com, id smtpd026480; Mon Aug 18 01:18:27 1997 Message-ID: <33F7A24A.FF6D5DF@whistle.com> Date: Sun, 17 Aug 1997 18:15:54 -0700 From: Julian Elischer Organization: Whistle Communications X-Mailer: Mozilla 3.0Gold (X11; I; FreeBSD 2.2-CURRENT i386) MIME-Version: 1.0 To: Garrett Wollman CC: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: Re: cvs commit: src/sys/kern kern_synch.c References: <199708161907.MAA10325@freefall.freebsd.org> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk Garrett Wollman wrote: > > wollman 1997/08/16 12:07:22 PDT > > Modified files: > sys/kern kern_synch.c > Log: > Dejulianize DIAGNOSTIC panic code. The types are wrong; probably there's > a missing dereference. > > Revision Changes Path > 1.35 +6 -4 src/sys/kern/kern_synch.c A word to me would have been appreciated.. A side effect of the test you removed is that it is now dereferencing a pointer that is not tested against being NULL which was one of the reasons for that test. it IS very unlikely that this would occur, however since I am seeing misbehaviour in these linked lists, I wanted to be cautious about what I assume.. (a null pointer here would not be dangerous except for this test and I could imagine it legally happenning. (though it probably doesn't)) I will re-commit a cleaner version (but I will test against NULL.)