From owner-cvs-all@FreeBSD.ORG Fri Apr 22 20:16:14 2005 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 770A316A4CE; Fri, 22 Apr 2005 20:16:14 +0000 (GMT) Received: from tigra.ip.net.ua (tigra.ip.net.ua [82.193.96.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id A0C2B43D41; Fri, 22 Apr 2005 20:16:13 +0000 (GMT) (envelope-from ru@ip.net.ua) Received: from localhost (rocky.ip.net.ua [82.193.96.2]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id j3MKJXNs012631; Fri, 22 Apr 2005 23:19:33 +0300 (EEST) (envelope-from ru@ip.net.ua) Received: from tigra.ip.net.ua ([82.193.96.10]) by localhost (rocky.ipnet [82.193.96.2]) (amavisd-new, port 10024) with LMTP id 98008-19; Fri, 22 Apr 2005 23:16:08 +0300 (EEST) Received: from heffalump.ip.net.ua (heffalump.ip.net.ua [82.193.96.213]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id j3MKJWNN012628 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 22 Apr 2005 23:19:32 +0300 (EEST) (envelope-from ru@ip.net.ua) Received: (from ru@localhost) by heffalump.ip.net.ua (8.13.3/8.13.3) id j3MKGFpE046163; Fri, 22 Apr 2005 23:16:15 +0300 (EEST) (envelope-from ru) Date: Fri, 22 Apr 2005 23:16:15 +0300 From: Ruslan Ermilov To: Marcel Moolenaar Message-ID: <20050422201615.GD23926@ip.net.ua> References: <20050422.114615.71130404.imp@bsdimp.com> <20050422175324.GA32739@ip.net.ua> <20050422184922.GA41457@ns1.xcllnt.net> <20050422.125712.78748765.imp@bsdimp.com> <20050422200341.GA23926@ip.net.ua> <1b042838f6396ae9665fcb2f41f1c9a7@xcllnt.net> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="d9ADC0YsG2v16Js0" Content-Disposition: inline In-Reply-To: <1b042838f6396ae9665fcb2f41f1c9a7@xcllnt.net> User-Agent: Mutt/1.5.9i X-Virus-Scanned: by amavisd-new at ip.net.ua cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: Warner Losh cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/usr.sbin/config main.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Apr 2005 20:16:14 -0000 --d9ADC0YsG2v16Js0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Apr 22, 2005 at 01:08:14PM -0700, Marcel Moolenaar wrote: > On Apr 22, 2005, at 1:03 PM, Ruslan Ermilov wrote: >=20 > >>>What exactly is broken? I don't see a breakage, even when source > >>>files disappeared. I assume I must be forgetting something or not > >>>doing everything right. > >> > >>when an include file is removed, make depend can fail to recreate > >>.depend in the modules. > >> > >This is only a problem with NO_CLEAN builds, and it's not limited > >to just modules -- I often saw this problem with the world builds. >=20 > Ok. Does it help if there's an option to make that supresses the > automatic loading on .depend or more generically, allows one to > name the depend file and it merely defaults to .depend (suppression > is then accomplished by specifying /dev/null as the depend file)? > If such option would be used for "make depend", would that resolve > the problems in a generic way? >=20 Nope. We only regenerate .depend when its dependencies are changed. For bsd.prog.mk, this means that .depend is only regenerated when some of ${SRCS} are changed (but this does NOT cover headers these ${SRCS} include, and some of these headers may disappear). To put it differently: when a header disappears, the breakage is not at the "make depend" stage (which doesn't do anything), but at a later "make all" stage. I personally fail to see how this can be solved... :-( Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --d9ADC0YsG2v16Js0 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.0 (FreeBSD) iD8DBQFCaVuPqRfpzJluFF4RAghYAJwKmQrSDX7XfWOa+Z11HlTXdpyKTACePql9 GW/cAFBgR/gGeLqepo93Rnc= =x3Rm -----END PGP SIGNATURE----- --d9ADC0YsG2v16Js0--