From nobody Tue Feb 22 09:20:08 2022 X-Original-To: ports@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 9009A19DD70A; Tue, 22 Feb 2022 09:20:14 +0000 (UTC) (envelope-from junchoon@dec.sakura.ne.jp) Received: from www121.sakura.ne.jp (www121.sakura.ne.jp [153.125.133.21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4K2ttP2z7Bz3tyC; Tue, 22 Feb 2022 09:20:12 +0000 (UTC) (envelope-from junchoon@dec.sakura.ne.jp) Received: from kalamity.joker.local (123-48-130-181.area1b.commufa.jp [123.48.130.181]) (authenticated bits=0) by www121.sakura.ne.jp (8.16.1/8.16.1/[SAKURA-WEB]/20201212) with ESMTPA id 21M9K8ph099793; Tue, 22 Feb 2022 18:20:09 +0900 (JST) (envelope-from junchoon@dec.sakura.ne.jp) Date: Tue, 22 Feb 2022 18:20:08 +0900 From: Tomoaki AOKI To: Tatsuki Makino Cc: Stephen Montgomery-Smith , Craig Leres , "Alex V. Petrov" , chromium@FreeBSD.org, ports@FreeBSD.org Subject: Re: FreeBSD Port: chromium-98.0.4758.102 Error build on 13-stable Message-Id: <20220222182008.5d231b8bb3f812691d6f8343@dec.sakura.ne.jp> In-Reply-To: References: <240efd99-514a-3b21-85cf-361e0087aef2@FreeBSD.org> <20220222065318.29e395623073010db2e02961@dec.sakura.ne.jp> Organization: Junchoon corps X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; amd64-portbld-freebsd13.0) List-Id: Porting software to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-ports List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports@freebsd.org X-BeenThere: freebsd-ports@freebsd.org Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4K2ttP2z7Bz3tyC X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of junchoon@dec.sakura.ne.jp has no SPF policy when checking 153.125.133.21) smtp.mailfrom=junchoon@dec.sakura.ne.jp X-Spamd-Result: default: False [0.96 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; MV_CASE(0.50)[]; RCPT_COUNT_FIVE(0.00)[6]; HAS_ORG_HEADER(0.00)[]; NEURAL_HAM_SHORT(-0.82)[-0.819]; FREEMAIL_TO(0.00)[hotmail.com]; RECEIVED_SPAMHAUS_PBL(0.00)[123.48.130.181:received]; RCVD_TLS_LAST(0.00)[]; R_DKIM_NA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; MID_RHS_MATCH_FROM(0.00)[]; ASN(0.00)[asn:7684, ipnet:153.125.128.0/18, country:JP]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-0.62)[-0.617]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[sakura.ne.jp]; AUTH_NA(1.00)[]; NEURAL_SPAM_MEDIUM(1.00)[0.999]; TO_MATCH_ENVRCPT_SOME(0.00)[]; R_SPF_NA(0.00)[no SPF record]; MLMMJ_DEST(0.00)[ports,chromium]; FREEMAIL_CC(0.00)[gmail.com,freebsd.org,FreeBSD.org]; RCVD_COUNT_TWO(0.00)[2] X-ThisMailContainsUnwantedMimeParts: N On Tue, 22 Feb 2022 12:44:16 +0900 Tatsuki Makino wrote: > Hello. > > What are the files that exist in /usr/ports/www/chromium/files/patch-third__party_nasm_config_config-linux.h doing? > Isn't it like mempcpy exists but HAVE_MEMPCPY is not defined, so we see this and get an error? > > Regards. It patches the file controlling several options for building bundled nasm. IIUC, as I'm not a member of chromium team, patchset are modified to share with OpenBSD chromium team in conjunction with upgrading to 98.0.4758.102. With this change, FreeBSD-specific patch and corresponding portion of Makefike introduced by bug 257352 [1], then, modified again by Bug 258271 [2]. Fix is ongoing at [2], currently by [3]. The proposed patch [3] can be placed to www/chromium/files/ as is, and builds fine on stable/13, amd64 git c39ff2415cb9 for me. [1] https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=257352 [2] https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=258271 [3] https://bz-attachments.freebsd.org/attachment.cgi?id=231983 Some details: FreeBSD src main before git ee37f64cf875, stable/13 before git dba677d13b26 and all revisions of stable/12 don't have mempcpy() yet. Not sure but maybe OpenBSD, too. This is why HAVE_MEMPCPY part of {WRKSRC}/third_party/nasm/config/config-linux.h is patched to disable by the patch you mentioned and cause of this breakage on main and stable/13 including and after above-mentioned commit. I'm not familiar wit gn build system, but maybe proposed patch [3] toggles HAVE_MEMPCPY defined again (or something equivalent) for all revisions having mempcpy() defined in /usr/include/string.h. -- Tomoaki AOKI