Date: Tue, 28 Jul 2009 10:35:59 -0500 From: Brooks Davis <brooks@freebsd.org> To: Pawel Jakub Dawidek <pjd@freebsd.org> Cc: freebsd-rc@freebsd.org Subject: Re: Review request. Message-ID: <20090728153559.GB72994@lor.one-eyed-alien.net> In-Reply-To: <20090728132938.GG1690@garage.freebsd.pl> References: <20090728132938.GG1690@garage.freebsd.pl>
next in thread | previous in thread | raw e-mail | index | archive | help
--6sX45UoQRIJXqkqR Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 28, 2009 at 03:29:38PM +0200, Pawel Jakub Dawidek wrote: > Hi. >=20 > I'm looking for a review of the following: >=20 > Currently there is a problem with fscking UFS file systems created on > top of ZVOLs. The problem is that rc.d/fsck runs before rc.d/zfs. The > latter makes ZVOLs to appear in /dev/. In such case rc.d/fsck cannot > find devfs entry and aborts. We cannot simply move rc.d/zfs before > rc.d/fsck, because we first want kern.hostid to be configured (by > rc.d/hostid). If we won't wait (hostid will be 0) we can reuse disks > which are in use by different systems (eg. in SAN/NAS environment). > We also cannot move rc.d/hostid before rc.d/fsck, because rc.d/hostid on > first system start stores generated kern.hostuuid in /etc/hostid file, > so it needs root file system to be mounted read-write. > =20 > My fix is to split rc.d/hostid so that rc.d/hostid (which will now run > before rc.d/fsck) only generates hostid and sets up sysctls, but doesn't > touch root file system and rc.d/hostid_save (which is run after > rc.d/root) and only creates /etc/hostid file. > =20 > With that in place, I can move ZVOL initialization to dedicated > rc.d/zvol script which runs before rc.d/fsck. >=20 > The patch is here: >=20 > http://people.freebsd.org/~pjd/patches/zvol_fsck.patch This looks fine to me and seems like a good solution to this problem. -- Brooks --6sX45UoQRIJXqkqR Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iD8DBQFKbxreXY6L6fI4GtQRAuTnAKCy09a3wJd+KB/i0qzF24U/sWxkVwCeMyQm 5rLlYD0HyI8g7R//wouRNxU= =5ozU -----END PGP SIGNATURE----- --6sX45UoQRIJXqkqR--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090728153559.GB72994>