From owner-freebsd-ipfw@FreeBSD.ORG  Mon Feb 23 10:03:53 2004
Return-Path: <owner-freebsd-ipfw@FreeBSD.ORG>
Delivered-To: freebsd-ipfw@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 6885316A4CE; Mon, 23 Feb 2004 10:03:53 -0800 (PST)
Received: from mail.alkar.net (mail.alkar.net [195.248.191.95])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 3FB2B43D1D; Mon, 23 Feb 2004 10:03:52 -0800 (PST)
	(envelope-from mav@alkar.net)
Received: from [195.248.178.122] (HELO alkar.net)
  by mail.alkar.net (CommuniGate Pro SMTP 4.1.8)
  with ESMTP id 148538026; Mon, 23 Feb 2004 20:03:50 +0200
Message-ID: <403A4085.6070202@alkar.net>
Date: Mon, 23 Feb 2004 20:03:49 +0200
From: Alexander Motin <mav@alkar.net>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US;
	rv:1.5b) Gecko/20030827
X-Accept-Language: ru, uk, en-us, en
MIME-Version: 1.0
To: Andre Oppermann <andre@freebsd.org>
References: <c0soic$1njq$2@pandora.alkar.net.lucky.freebsd.net>
	<c1d9id$10qf$1@pandora.alkar.net> <403A323C.A8685981@freebsd.org>
In-Reply-To: <403A323C.A8685981@freebsd.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
cc: freebsd-net@freebsd.org
cc: freebsd-ipfw@freebsd.org
Subject: Re: Generating 'Fragment Needed but DF was Set' ICMP & Dummynet
X-BeenThere: freebsd-ipfw@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: IPFW Technical Discussions <freebsd-ipfw.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ipfw>,
	<mailto:freebsd-ipfw-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ipfw>
List-Post: <mailto:freebsd-ipfw@freebsd.org>
List-Help: <mailto:freebsd-ipfw-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ipfw>,
	<mailto:freebsd-ipfw-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 23 Feb 2004 18:03:53 -0000

Andre Oppermann wrote:

> Alexander Motin wrote:
> 
>>Here are my patches for this problem for FreeBSD 4.8 and 5.2.
>>Review them please.
> 
> Doing a mcopy is pretty ugly... but ip_output() doesn't offer any way
> of saying "don't flush packet but leave it for icmp error messages".
> 
> So the better fix would be to teach that to ip_output() and change
> the callers accordingly.  Actually I'll have a patch to do that ready
> in a couple of hours.  Then I'll commit your patch w/o the packet
> copying stuff.

This was taken from ip_forward(). :) If you say that it can be reworked 
here then it can be reworked there too for increasing performance.

-- 
Alexander Motin mav@alkar.net
ISP "Alkar-Teleport"