From owner-svn-src-all@freebsd.org Thu Jan 9 00:34:33 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id AA075221851; Thu, 9 Jan 2020 00:34:33 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-ot1-f65.google.com (mail-ot1-f65.google.com [209.85.210.65]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47tRvY443rz4Mgh; Thu, 9 Jan 2020 00:34:33 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-ot1-f65.google.com with SMTP id k14so5520153otn.4; Wed, 08 Jan 2020 16:34:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=9PITG2Jep69Iye7nNTiTdmWORfQZo1Uyet5TeLUjZzQ=; b=S8VMsp1eZT3MdCkO5SSs0niXIW4GwHndeoWUshmLaInhDhRThIK07EvUzhm/u6V8hS LJdeSJ61igdnesdiZIew11H0n4y+GkDy6rqD+sbCq+WBYRnuQp0zXQVq+uH4aaHykwET az7NuN6BRy3lXVThq37SaWqXtG5Afk/WO6mm2R9GC//Cs4of0ULCkFEtnesF1O38dP/k nJU0nHfYpNiq9fXK8UPYMvezhhHHwrI0O9GmhD2zhg4NyiBE+04n+Nv6OLyXzZ6xbAwf bTHwfowzAb594ygxDg6bZCH9BB8sNbHqc1DrASJ+1HO4k9AP1TYAQI3SgDKxUTHMKQUr 7z2A== X-Gm-Message-State: APjAAAWaW1nWuYTIn/3cmP69HN4S1ukcNMdIng/rhCbZim7wBDEi4+Gz F8nKernSw21cB8nc+NT4QBh555Tx X-Google-Smtp-Source: APXvYqw/xvgVEw824vXI4xNPnlDRd6N8Tyw6kTfIK7swnr6hfdU/p4/CkYMNVYBLVzG2sfVvq+PQZw== X-Received: by 2002:a05:6830:151a:: with SMTP id k26mr6727233otp.74.1578530072226; Wed, 08 Jan 2020 16:34:32 -0800 (PST) Received: from mail-oi1-f179.google.com (mail-oi1-f179.google.com. [209.85.167.179]) by smtp.gmail.com with ESMTPSA id p83sm1623031oia.51.2020.01.08.16.34.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Jan 2020 16:34:32 -0800 (PST) Received: by mail-oi1-f179.google.com with SMTP id 13so2520386oij.13; Wed, 08 Jan 2020 16:34:32 -0800 (PST) X-Received: by 2002:aca:f484:: with SMTP id s126mr1070526oih.48.1578530071480; Wed, 08 Jan 2020 16:34:31 -0800 (PST) MIME-Version: 1.0 References: <202001082037.008Kb4kH089848@repo.freebsd.org> In-Reply-To: <202001082037.008Kb4kH089848@repo.freebsd.org> Reply-To: cem@freebsd.org From: Conrad Meyer Date: Wed, 8 Jan 2020 16:34:20 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r356513 - in head/contrib/llvm-project/libunwind: include src To: Ed Maste Cc: src-committers , svn-src-all , svn-src-head Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 47tRvY443rz4Mgh X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-6.00 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Jan 2020 00:34:33 -0000 I definitely don't condone this. I would prefer it be reverted. It has never been tested. It's got my name in the commit message, suggesting some level of my approval; I absolutely do not approve of it in any way. Cheers, Conrad On Wed, Jan 8, 2020 at 12:37 PM Ed Maste wrote: > > Author: emaste > Date: Wed Jan 8 20:37:03 2020 > New Revision: 356513 > URL: https://svnweb.freebsd.org/changeset/base/356513 > > Log: > libunwind: untested attempt to fix sparc64 build > > sparc64 is the only architecture currently using the DWARF unwinder from > GCC 4.2.1. Old GCC and related libraries are being removed soon; absent > other changes sparc64 would be left with no unwinder when that happens. > > Instead, commit these changes which should at least allow the LLVM > unwinder to build. Someone with access to the obolete sparc64 hardware > supported by FreeBSD will need to test the result. > > PR: 233405 > Submitted by: cem