Date: Wed, 8 Jan 2020 16:34:20 -0800 From: Conrad Meyer <cem@freebsd.org> To: Ed Maste <emaste@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head <svn-src-head@freebsd.org> Subject: Re: svn commit: r356513 - in head/contrib/llvm-project/libunwind: include src Message-ID: <CAG6CVpVHunZXK5EEi07T=sBcAcQcwiMwV%2B4Q3GYPJ_ByOSLXDA@mail.gmail.com> In-Reply-To: <202001082037.008Kb4kH089848@repo.freebsd.org> References: <202001082037.008Kb4kH089848@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
I definitely don't condone this. I would prefer it be reverted. It has never been tested. It's got my name in the commit message, suggesting some level of my approval; I absolutely do not approve of it in any way. Cheers, Conrad On Wed, Jan 8, 2020 at 12:37 PM Ed Maste <emaste@freebsd.org> wrote: > > Author: emaste > Date: Wed Jan 8 20:37:03 2020 > New Revision: 356513 > URL: https://svnweb.freebsd.org/changeset/base/356513 > > Log: > libunwind: untested attempt to fix sparc64 build > > sparc64 is the only architecture currently using the DWARF unwinder from > GCC 4.2.1. Old GCC and related libraries are being removed soon; absent > other changes sparc64 would be left with no unwinder when that happens. > > Instead, commit these changes which should at least allow the LLVM > unwinder to build. Someone with access to the obolete sparc64 hardware > supported by FreeBSD will need to test the result. > > PR: 233405 > Submitted by: cem
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAG6CVpVHunZXK5EEi07T=sBcAcQcwiMwV%2B4Q3GYPJ_ByOSLXDA>