Date: Fri, 4 Jun 2021 10:06:18 +0000 From: Alexey Dokuchaev <danfe@freebsd.org> To: Piotr Kubaj <pkubaj@freebsd.org> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 5d304c338aba - main - games/fheroes2: update to 0.9.4 Message-ID: <YLn7Grm5oFyRp9FB@FreeBSD.org> In-Reply-To: <202106040953.1549rbHY052844@gitrepo.freebsd.org> References: <202106040953.1549rbHY052844@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Jun 04, 2021 at 09:53:37AM +0000, Piotr Kubaj wrote:
> commit 5d304c338abaef672b8392ff2d2d0b554106950c
>
> games/fheroes2: update to 0.9.4
>
> @@ -8,20 +8,15 @@ COMMENT= Free implementation of Heroes of Might and Magic II engine
> LICENSE= GPLv2
> LICENSE_FILE= ${WRKSRC}/LICENSE
>
> -LIB_DEPENDS= libtinyxml.so:textproc/tinyxml
> +LIB_DEPENDS= libpng16.so:graphics/png
It should be spelled as ``libpng.so:graphics/png'', without 16.
> -LDFLAGS+= -ltinyxml
> -MAKE_ENV= WITHOUT_BUNDLED_LIBS=1
So, what happened to TinyXML dependency? Is it no longer needed,
or bundled version is used now for some reason? This wasn't
mentioned in the commit log.
> +PLIST_FILES= bin/${PORTNAME} \
> + ${DOCSDIR}/README.txt \
> + ${DOCSDIR}/changelog.txt
Docfiles should probably be listed as PORTDOCS, not be part of
the PLIST_FILES.
./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?YLn7Grm5oFyRp9FB>