From owner-freebsd-ports@FreeBSD.ORG  Thu Jul 31 12:50:10 2008
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: freebsd-ports@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id C6D441065684
	for <freebsd-ports@freebsd.org>; Thu, 31 Jul 2008 12:50:10 +0000 (UTC)
	(envelope-from freebsd-ports@m.gmane.org)
Received: from ciao.gmane.org (main.gmane.org [80.91.229.2])
	by mx1.freebsd.org (Postfix) with ESMTP id 8387C8FC21
	for <freebsd-ports@freebsd.org>; Thu, 31 Jul 2008 12:50:10 +0000 (UTC)
	(envelope-from freebsd-ports@m.gmane.org)
Received: from list by ciao.gmane.org with local (Exim 4.43)
	id 1KOXbc-0006pA-0D
	for freebsd-ports@freebsd.org; Thu, 31 Jul 2008 12:50:08 +0000
Received: from xdsl-10260.wroclaw.dialog.net.pl ([84.40.242.20])
	by main.gmane.org with esmtp (Gmexim 0.1 (Debian))
	id 1AlnuQ-0007hv-00
	for <freebsd-ports@freebsd.org>; Thu, 31 Jul 2008 12:50:07 +0000
Received: from mwisnicki+freebsd by xdsl-10260.wroclaw.dialog.net.pl with
	local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00
	for <freebsd-ports@freebsd.org>; Thu, 31 Jul 2008 12:50:07 +0000
X-Injected-Via-Gmane: http://gmane.org/
To: freebsd-ports@freebsd.org
From: Marcin Wisnicki <mwisnicki+freebsd@gmail.com>
Date: Thu, 31 Jul 2008 12:49:58 +0000 (UTC)
Lines: 28
Message-ID: <g6scdm$21c$1@ger.gmane.org>
References: <20080730085123.81542622.wmoran@collaborativefusion.com>
	<g6ql7b$d5g$1@ger.gmane.org>
	<8543.59269510514$1217453541@news.gmane.org>
	<g6qoq7$pm4$1@ger.gmane.org> <op.ue4mo7ha9aq2h7@mezz.mezzweb.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-Complaints-To: usenet@ger.gmane.org
X-Gmane-NNTP-Posting-Host: xdsl-10260.wroclaw.dialog.net.pl
User-Agent: Pan/0.132 (Waxed in Black)
Sender: news <news@ger.gmane.org>
Subject: Re: Problems with portupgrade && xscreensaver-gnome
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 31 Jul 2008 12:50:10 -0000

On Wed, 30 Jul 2008 17:42:33 -0500, Jeremy Messenger wrote:

> On Wed, 30 Jul 2008 17:09:11 -0500, Marcin Wisnicki
> <mwisnicki+freebsd@gmail.com> wrote:
> 
>> If .warning breaks portupgrade I can change it to IGNORE.
> 
> I prefer remove .warning and IGNORE. If user wants to enable keyring
> then the WITH_KEYRING should be always enable PAM, no matter if user has
> selected it disable. And, tweak comment in OPTIONS for (reqiure PAM).

OK, I've sent patches to PR.

http://www.freebsd.org/cgi/query-pr.cgi?pr=126114

As suggested, .warning was removed, option description improved and 
KEYRING will force PAM.

http://www.freebsd.org/cgi/query-pr.cgi?pr=126115

Like above, gnome-screensaver has similar .warning, but because of 
partially broken pam support, the logic is reversed: lack of pam will 
disable keyring.
Also I've introduced some anti foot-shooting measures until the problem 
is fixed, so users of g-s won't end up with broken setup by selecting 
wrong options.
Maybe options should be hidden behind GNOME_SCREENSAVER_WITH_BROKEN_PAM 
conditional ?