From owner-cvs-src@FreeBSD.ORG Mon Mar 15 07:42:18 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5402A16A4D1; Mon, 15 Mar 2004 07:42:18 -0800 (PST) Received: from canning.wemm.org (canning.wemm.org [192.203.228.65]) by mx1.FreeBSD.org (Postfix) with ESMTP id 284DF43D31; Mon, 15 Mar 2004 07:42:18 -0800 (PST) (envelope-from peter@evilpete.dyndns.org) Received: from fw.wemm.org (canning.wemm.org [192.203.228.65]) by canning.wemm.org (Postfix) with ESMTP id CC6BF2A933; Mon, 15 Mar 2004 07:42:17 -0800 (PST) (envelope-from peter@overcee.wemm.org) Received: from overcee.wemm.org (overcee.wemm.org [10.0.0.3]) by fw.wemm.org (Postfix) with ESMTP id 671CBE259; Mon, 15 Mar 2004 07:42:17 -0800 (PST) (envelope-from peter@overcee.wemm.org) Received: from overcee.wemm.org (localhost [127.0.0.1]) by overcee.wemm.org (8.12.11/8.12.11) with ESMTP id i2FFfgSD039146; Mon, 15 Mar 2004 07:41:42 -0800 (PST) (envelope-from peter@overcee.wemm.org) Received: from localhost (localhost [[UNIX: localhost]]) by overcee.wemm.org (8.12.11/8.12.11/Submit) id i2FFfcgH039145; Mon, 15 Mar 2004 07:41:38 -0800 (PST) (envelope-from peter) From: Peter Wemm To: Takahashi Yoshihiro Date: Mon, 15 Mar 2004 07:41:38 -0800 User-Agent: KMail/1.6 References: <20040314.125403.41652080.nyan@jp.FreeBSD.org> <20040315.175959.11208797.imp@bsdimp.com> <20040315.224828.41670431.nyan@jp.FreeBSD.org> In-Reply-To: <20040315.224828.41670431.nyan@jp.FreeBSD.org> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200403150741.38591.peter@wemm.org> cc: src-committers@FreeBSD.org cc: peter@FreeBSD.org cc: cvs-src@FreeBSD.org cc: cvs-all@FreeBSD.org cc: obrien@FreeBSD.org cc: imp@bsdimp.com Subject: Re: cvs commit: src/sys/i386/include dvcfg.h physio_proc.h src/sys/amd64/include dvcfg.h physio_proc.h src/sys/compat/netbsd dvcfg.h physio_proc.h src/sys/dev/ct bshw_machdep.c ct.c ct_isa.c src/sys/dev/ncv ncr53c500.c ncr53c500_pccard.c ncr53c500hw.h ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Mar 2004 15:42:18 -0000 On Monday 15 March 2004 05:48 am, Takahashi Yoshihiro wrote: > In article <20040315.175959.11208797.imp@bsdimp.com> > > "M. Warner Losh" writes: > > : sys/dev// is best. Right now dev/ only has > > : directories, but I'm not sure what [pseudo] device these should > > : go with. > > > > dev/ic already exists for this purpose. Or at least one similar to > > it. > > No. dev/ic is for chip specific registers, not for common files > between drivers. Not to mention that these are stub files.. for example, physio_proc.h is: struct physio_proc { }; static __inline struct physio_proc * physio_proc_enter(bp) struct buf *bp; { return NULL; } static __inline void physio_proc_leave(pp) struct physio_proc *pp; { } dvcfg.h is 5 macros and a 2-item struct. Anyway, I made the mistake of assuming that these were for NetBSD API compatability. I initially thought that the dvcfg.h file was for interfacing with NetBSD's config(8) system. But instead it seems they are for a variant of NetBSD. I don't really care where they go, as long as it isn't in the MD include areas (they are not MD!), and not in sys/. My favorites right now are dev/pc98/* or compat/pc98/*. I would also like sys/device_port.h to move there too since it is used by the same group of ct/ncv/nsp/stg drivers. -- Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com "All of this is for nothing if we don't go to the stars" - JMS/B5