From nobody Fri Sep 27 10:07:14 2024 X-Original-To: current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XFR3Y3bxdz5XnkK for ; Fri, 27 Sep 2024 10:07:37 +0000 (UTC) (envelope-from garyj@gmx.de) Received: from mout.gmx.net (mout.gmx.net [212.227.17.20]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mout.gmx.net", Issuer "Telekom Security ServerID OV Class 2 CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XFR3X6pJ5z4Wrg for ; Fri, 27 Sep 2024 10:07:36 +0000 (UTC) (envelope-from garyj@gmx.de) Authentication-Results: mx1.freebsd.org; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.de; s=s31663417; t=1727431653; x=1728036453; i=garyj@gmx.de; bh=6U9/DR4x2tDDYaqapU1ja4SrKvKbnXGKTYeIPidsUDU=; h=X-UI-Sender-Class:Date:From:To:Cc:Subject:Message-ID:In-Reply-To: References:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=pVMuEZ8S332gm8TK2TdoYzweIMCGRshwvfLCDecl6QJleuL16mete3Z0OVk+b7kI qNLSM6R1ewXUUAfFQpQ/FimmKBwfU4O13GVrAWDbbUuJSof8QJtE2jc2gliVPpGNf I84IYIl/PUir7PTTkTs1NqHcg6a2pd1ghn7aSPeujga4mo6n/D2ieBl28fBbj6cVs kF6GpvErqP8Ewvj4gs6mDGdX3aPwoQYaFRtFS9Z8Zz/n+N2MYzVFJMsmlODrO/mYH dzRVtAXnpNqifJVYXsMhchhb9aXr1yOyDurPcDxXPB17MLnGz0Bd5lCDffmn90CoK +RTPWGJtdrRMe2fFEg== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from ernst.home ([217.226.54.45]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MGhyc-1sgQUx380g-00AIfC; Fri, 27 Sep 2024 12:07:33 +0200 Date: Fri, 27 Sep 2024 10:07:14 +0000 From: Gary Jennejohn To: Ian FREISLICH Cc: FreeBSD Current Subject: Re: Is INET6 a required option these days? (kernel build failure) Message-ID: <20240927120714.35169c6c@ernst.home> In-Reply-To: <229d4fea-2eed-4710-99f8-f4f91ed539c0@gmail.com> References: <229d4fea-2eed-4710-99f8-f4f91ed539c0@gmail.com> Reply-To: garyj@gmx.de X-Mailer: Claws Mail 3.19.1 (GTK+ 2.24.33; amd64-portbld-freebsd14.0) List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:cjzaQRfq+uVWy3xx52IulyE2yirCOwZm4fZVnf9ZkTCPsHd7vQZ y34t+ncI+mbKDjM8m7eOmHVjuK1tlr+paK+oJ/LGWzLyxKTUn9nHdEFlnyay7eo0g+8GJJW LIJFC2Wy/mdhSc3NjKTYgTVYBQRtOc7uhHGjWCWhH8WoNTnMN08c6opHtdTZ3uDwvV5nt7t niGHwmcWguyGh4ocfmrfA== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:T3Du02emjwo=;2GRlAAu+Wnt2BRnGmqSokz6gKgN +ENDFV8uonhsMOjUg4pOi7f9vS5yqB2+rsUNLCZ+yWQOrN5w+uRp4YHGI+jKOa+1cUPdb/P5Y bwfdER17xpsoPuicQJ7jiG0/Scxg+BAAqWTQqdX83px/E+S/0pqfdk7gVOZWmDSnDlvCqnH62 t31V28N6fD/IGCA4wsBYwE7TmPFinR8eXfrHAugJ4rpZKaSDs6eC/ItnpTO9cvZhWq1NH0bbV qcyc28I5LgemPtSa6tfo2wnUTKxKF5wD4zh+ykKEvy8/B4auMCDDyS+Xk30UzMZWPHatmwwYU 3Hyx6KOtPc448y9AYFY1nWF+8vUL1QmxTDZbiVYaR20xTRXqAlgE1VTs/EtZHlHZLb70jfvJe UIHZU/3gM60Gy5g2WuLg+0f6jHMv/P7GzZ6Gcou3XAbznXYlLZcdKdyyVSBRYva3CMfRETR6H 4t2nYR7BGsR1MtsFaW40cVq0fEo2zx1zF3rqZ10SPKm24ldnUMIY3VB68MkwQ0KSP9tHKXZkV uZrthreIhJnRAy2y7JSFN6OVlL6bctfd7L4G7UOpomUkLar40QXfzp35Bqi0R6ILmdZemiNlP pzkQDFFli9XWCyH1KCaZqgE2rxIIibpcGHPOCsInOKLmHrRWqbbtwj7lsLwqpWvNyGHGOevpo DwSigHNAZXmFRrYNrmufjuVUqvntWvfwBybTF6kp3QEUh56VMYzIJtcpmzHLrV/Rz5OLS93s3 M7kjwC5ioXDKKclDdE9x6r+PwvjixOvSpCEm3z8J1m6bki9JFf6r58TFIfu7IVe3wptKMvPVO Ii6DzrJ8V+fgHPlDK7tIjxo6VpI5VkQTBxAXRFZ9fABf4= X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:8560, ipnet:212.227.0.0/16, country:DE] X-Rspamd-Queue-Id: 4XFR3X6pJ5z4Wrg X-Spamd-Bar: ---- On Thu, 26 Sep 2024 14:58:40 -0400 Ian FREISLICH wrote: > Lately there have been a couple of commits that fail to build because v6= being compiled in despite INET6 being undefined. I think the latest is 90= 5db4aa88775865097714c170f4503da385747c. > > /usr/src/sys/netpfil/pf/pf.c:8762:38: error: no member named 'icmp6' in = 'union pf_headers'; did you mean 'icmp'? > =A08762 |=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 if (!pf_pull_h= dr(m, *off, &pd->hdr.icmp6, icmp_hlen, > > Ian > This happens now and then because most committers have INET6 enabled and they forget that INET6 is an option and not mandatory. I don't have INET6 enabled and have reported a number of problems in the source as a result of that. In general it's pretty simple to fix these problems by merely adding #ifdef INET6 ... #endif to the code. =2D- Gary Jennejohn