Date: Tue, 14 Sep 1999 15:48:56 +0100 From: Tony Finch <fanf@demon.net> To: Matthew Dillon <dillon@apollo.backplane.com> Cc: Tony Finch <fanf@demon.net>, hackers@FreeBSD.ORG Subject: Re: mounting a partition more than once Message-ID: <E11QttA-000E4G-00@fanf.noc.demon.net> In-Reply-To: <199909140504.WAA27333@apollo.backplane.com> References: <E11QZ03-000DDr-00@fanf.noc.demon.net> <199909132116.OAA25920@apollo.backplane.com> <E11Qe1j-000DRT-00@fanf.noc.demon.net> <199909140504.WAA27333@apollo.backplane.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Matthew Dillon <dillon@apollo.backplane.com> wrote: > Tony Finch <fanf@demon.net> wrote: > :Matthew Dillon <dillon@apollo.backplane.com> wrote: > :> > :> Also, this may not be the best place to put the code. It make sense > :> to be able to mount a block device multiple times in a read-only > :> fashion, but the code should be in the open for the block device > :> rather then in UFS/FFS, so it can be used with other filesystems > :> and for other purposes. > : > :Yes, it's evident that this is true because I had to hack around > :essentially the same test in both spec_open and ffs_mountfs; removing > :the checks down from ffs_mountfs so it relies on spec_mount to DTRT > :would be neater, I think. > > Yes. I think this is the right track to take. The result will be > more useful to the system and probably a cleaner patch as well. I found some problems with the patch last night (after some suggestions from a colleague). There needs to be some additional checking at the level of the syscall code, I think, to prevent mounting the same partition at the same point more than once -- this causes a "lockmgr: locking against myself" panic when unmounting. I also missed out some checks from the remount code... Tony. -- f.a.n.finch dot@dotat.at fanf@demon.net e pluribus unix To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?E11QttA-000E4G-00>