From owner-svn-src-all@FreeBSD.ORG Sun Feb 15 21:26:22 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 6EC29B37; Sun, 15 Feb 2015 21:26:22 +0000 (UTC) Received: from mail-la0-f49.google.com (mail-la0-f49.google.com [209.85.215.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id E6F03A47; Sun, 15 Feb 2015 21:26:21 +0000 (UTC) Received: by labhs14 with SMTP id hs14so24607697lab.1; Sun, 15 Feb 2015 13:26:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=uCl5NyVg8WZagQ24aOMk6DGkssbnzY509McMnz7WKRk=; b=RUa8aBkxUe/Rvk99IsQxkMkkIvebLhsLDE/6J8laNh398OyJVYKMoHbpiu30PlTlXO huBelTbpTOHRFNOl4oKymHWd4d1QzkMbXNpLUXnFESggxadxFIq0bA0xnKB+zzE6Fyfw F1/+huBWz+ds9lvJmuKoh5QOCOZD9Uub14tS79Lm6TziOOdUUVRXFgPC9eQwlvgIl5Fs U6au2S2OLyPQBuaF16UDnLxUmTY/7OWhUB/ZlMYW86NKuBg1ICBfPfAmZnWThQL/qU36 H972+D3tWXMomIq34phm7gLtglPIxPb2Tlj2dAusyWi+bhMrozzi1Wmx+RsDX/xXdfI0 y+dA== MIME-Version: 1.0 X-Received: by 10.112.137.38 with SMTP id qf6mr19043822lbb.59.1424035578631; Sun, 15 Feb 2015 13:26:18 -0800 (PST) Sender: crodr001@gmail.com Received: by 10.112.28.40 with HTTP; Sun, 15 Feb 2015 13:26:18 -0800 (PST) In-Reply-To: <20150215190100.GQ15484@FreeBSD.org> References: <201501060903.t06934qp081875@svn.freebsd.org> <20150122012709.GM15484@FreeBSD.org> <54C16715.6060701@gmx.com> <20150122222314.GO15484@FreeBSD.org> <20150215190100.GQ15484@FreeBSD.org> Date: Sun, 15 Feb 2015 13:26:18 -0800 X-Google-Sender-Auth: FHLKL0r2UYtdQX5jIwpt0gCsP9s Message-ID: Subject: Re: svn commit: r276747 - head/sys/netpfil/pf From: Craig Rodrigues To: Gleb Smirnoff Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.18-1 Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , Nikos Vassiliadis , "src-committers@freebsd.org" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Feb 2015 21:26:22 -0000 On Sun, Feb 15, 2015 at 11:01 AM, Gleb Smirnoff wrote: > Craig, > > On Sat, Feb 14, 2015 at 07:35:53PM -0800, Craig Rodrigues wrote: > C> > On Thu, Jan 22, 2015 at 10:09:41PM +0100, Nikos Vassiliadis wrote: > C> > N> > Sorry guys, I backed this out due to broken kldunload of pf > module, > C> > which > C> > N> > is critical when you are working with pf bugs. > C> > N> > C> > N> For sure. 100% understood. > C> > N> > C> > N> > I had to backout r276746 as well, since it has numerous build > C> > breakages, > C> > N> > that are addressed by later revisions. > C> > N> > > C> > N> > That's my fault that I don't review in time, and I will try to > improve > C> > N> > the situation. > C> > N> > > C> > N> > Can you please replay r276746 again, addressing all the build > problems > C> > N> > and send the patch to me? You can user reviews.freebsd.org if > you > C> > want. > C> > N> > > C> > N> > I'd like to get this in, but in a better quality. > C> > N> > C> > N> I'd like to get involved again and help you fixing pf. Craig could > you > C> > N> replay 276746? > C> > C> I wish you could have fixed the pf unload problem without backing out > C> all these changes. I took all these changes from your projects/pf > branch, > C> which was starting to bitrot because it was not being sync'd with head. > C> > C> I got confirmation from several people that the fixes as they were > (after > C> the build break fixes), > C> actually fixed their issues with PF and VIMAGE, which have been pending > for > C> several > C> years now with no visible progress made. > C> > C> Most regular users of PF don't really kldunload it once it is used. > C> For development use, I've been testing inside bhyve VM's, which doesn't > C> solve the kldunload problem but allows testing and forward progress. > C> > C> Why do you want me to replay 276746 and give you a patch? > C> > C> Why don't you just do it yourself? > > Because it is responsibility of the committer, who broke something, to > fix it, not mine. > > Nevertheless, I tried to do that, and it took more than couple of hours, > but > I failed to untangle all the problems that r276746 brought and proceeded > with > checkout. > What are the problems in 276746 that you were unhappy with besides being unable to kldunload PF? With 276746, without the follow-on fixes, if you kldunload PF while VIMAGE is unabled, the kernel panics. That seems worse than being unable to kldunload PF. If I submit another patch, I am just going to commit it, but I don't know if you will be unhappy and revert it. -- Craig