From nobody Tue Apr 1 17:46:10 2025 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZRwQq2QlMz5rsk2; Tue, 01 Apr 2025 17:46:11 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ZRwQq0TBTz3L0l; Tue, 01 Apr 2025 17:46:11 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1743529571; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=1Xw9jURhhwzIYZdkOG5SKYY2XMC809JO4L1jYpq9+8M=; b=T3pgxlr8STwIaH6FGQJhKhDBqN5g3oUYXlpSWp9izGxcwK1CrbOJpoNRPIprEmQg7Vm0PY IgZlwdQWRLzJh0OJ7OM6YMwFuIXajIpU7/ZxMQTQG0eDaTnAbnuKsFXmqOPlewNrPQjPc9 n0QLutw+5MTU30X3UgyUDvMv1tjyD905sCeWq2DqeGfDYZuygoabkq2QyZENQIqcs1LWIL gZn/uR5OgfFKyht+5AjNfP/cwkfAaHhj+u36+ouBwPdso9bh1/sQMSyZ8Mu+zM+zNsD1Di JRwHD3IKBDB/dTfsXGefO7cWjEBgYVuBC2apqvRYLvXbaiOwdj3xczS8ksz7Lg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1743529571; a=rsa-sha256; cv=none; b=aRKggAHBJDmlKh2JW/R3j0Vyet22MlTeUxDQ7C0/HVFpGkM+9antuZoUSv1W79+tcFOkkw 63u7rTV0RFDLFtRpwdGAIJpncKo/2TZWLvZMWqhPHKrg++Z7QrkiPNKIduXogL0Yhi68zu AAWh1NovjP01P7QoZ2D+C1NNEq1fvmNS5OhtMz6P0mTWmunuTXkDli38HBp3ubYEw9PEvv vzYeWVzxOjWuCSpYEdo0xy7ANA0c3jBWAXMJmv3Cu2C8/hKn/RCQ7oFSTeVBbQ/5t1Y/s0 Uoc9GsJ9VaSeWo2iwTbu7HG2wOhT7HDRTiBwUOw+Zf3bLpMv0NMUuKCW+ZcGeQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1743529571; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=1Xw9jURhhwzIYZdkOG5SKYY2XMC809JO4L1jYpq9+8M=; b=JkjZgVe9M5sMEUxQYuHeb7VTLi0XZu76Eg1ljxB9CBGjjTjLJJn3mQnn7bSejUfCJzMNjI 9RjmRHnlBOPK9NS6U6DEHwf5T1G0iicnkTagwFCoSBy/mteVWL1xWS1wik3dW1jrZDklQK wgvPc4aeSPzfNMOtM21gQdgf3KAtnx3HbUYPtjJf35dQWINgYea0IGJjCKWSc8vGbwXQlW CljIBma4Te0K74/3ZSq5MK1la0Uy1S3DnRnJHqSaEHg6B4SO6PPvQY/iOyGmop7i4F3nOl cRWimncgfU1lcPq/lj9crt5Z3l+NyEBaw0tLNwqwcF36W2tFE85LFEO1ZgChuA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4ZRwQq03djzh3D; Tue, 01 Apr 2025 17:46:11 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 531HkAke050130; Tue, 1 Apr 2025 17:46:10 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 531HkAQb050127; Tue, 1 Apr 2025 17:46:10 GMT (envelope-from git) Date: Tue, 1 Apr 2025 17:46:10 GMT Message-Id: <202504011746.531HkAQb050127@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Colin Percival Subject: git: d3916945e4e1 - stable/14 - pci: Use a switch statement when reading ivars List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: cperciva X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: d3916945e4e11fae3898d497deccefb5143796d0 Auto-Submitted: auto-generated The branch stable/14 has been updated by cperciva: URL: https://cgit.FreeBSD.org/src/commit/?id=d3916945e4e11fae3898d497deccefb5143796d0 commit d3916945e4e11fae3898d497deccefb5143796d0 Author: Andrew Turner AuthorDate: 2024-12-12 16:30:02 +0000 Commit: Colin Percival CommitDate: 2025-04-01 17:43:57 +0000 pci: Use a switch statement when reading ivars In pci_host_generic.c use a switch statement rather than a series of if statements. Reviewed by: imp Sponsored by: Arm Ltd Differential Revision: https://reviews.freebsd.org/D48045 (cherry picked from commit fafb43abd0dcaf2d36ec7344f46e7e19c42be888) --- sys/dev/pci/pci_host_generic.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/sys/dev/pci/pci_host_generic.c b/sys/dev/pci/pci_host_generic.c index 19a2ec419ad0..37864da9baa4 100644 --- a/sys/dev/pci/pci_host_generic.c +++ b/sys/dev/pci/pci_host_generic.c @@ -369,13 +369,11 @@ generic_pcie_read_ivar(device_t dev, device_t child, int index, struct generic_pcie_core_softc *sc; sc = device_get_softc(dev); - - if (index == PCIB_IVAR_BUS) { + switch (index) { + case PCIB_IVAR_BUS: *result = sc->bus_start; return (0); - } - - if (index == PCIB_IVAR_DOMAIN) { + case PCIB_IVAR_DOMAIN: *result = sc->ecam; return (0); }