From owner-svn-src-all@freebsd.org Thu Jun 14 12:12:40 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CAFE31022C76 for ; Thu, 14 Jun 2018 12:12:40 +0000 (UTC) (envelope-from eadler@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 778DC873F5 for ; Thu, 14 Jun 2018 12:12:40 +0000 (UTC) (envelope-from eadler@freebsd.org) Received: from mail-yb0-f169.google.com (mail-yb0-f169.google.com [209.85.213.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) (Authenticated sender: eadler) by smtp.freebsd.org (Postfix) with ESMTPSA id 45769E7FF for ; Thu, 14 Jun 2018 12:12:40 +0000 (UTC) (envelope-from eadler@freebsd.org) Received: by mail-yb0-f169.google.com with SMTP id u11-v6so2133894ybi.8 for ; Thu, 14 Jun 2018 05:12:40 -0700 (PDT) X-Gm-Message-State: APt69E1k/Fhy7aaj7xj6p4JVgQbvkZssk9lcuf3PBsibo+OiqkXeElI/ /YEg2p8mHGGtjBlvzvXoRheC7iABE/MK8jCPwjNHtw== X-Google-Smtp-Source: ADUXVKJUv8dLZ7uDRXcY8gY0VdsBUrn23o12ZvUCNzJvNtX1apKDhA2iW0EwmQTWFLuvfRB02VByUDR6olPAmUSkXok= X-Received: by 2002:a25:500a:: with SMTP id e10-v6mr1233852ybb.87.1528978359750; Thu, 14 Jun 2018 05:12:39 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a25:ef50:0:0:0:0:0 with HTTP; Thu, 14 Jun 2018 05:12:09 -0700 (PDT) In-Reply-To: <20180610162653.GA2999@FreeBSD.org> References: <201805202319.w4KNJ9hj038452@repo.freebsd.org> <20180521094344.Q1053@besplex.bde.org> <20180521063953.GA70671@FreeBSD.org> <20180610122819.GA75055@FreeBSD.org> <20180610162653.GA2999@FreeBSD.org> From: Eitan Adler Date: Thu, 14 Jun 2018 05:12:09 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r333945 - head/usr.bin/top To: Alexey Dokuchaev Cc: Bruce Evans , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Jun 2018 12:12:41 -0000 On 10 June 2018 at 09:26, Alexey Dokuchaev wrote: > On Sun, Jun 10, 2018 at 08:56:24AM -0700, Eitan Adler wrote: >> On 10 June 2018 at 05:28, Alexey Dokuchaev wrote: >> > I've just tried the latest top(1). Now it's even worse: >> > ... >> > Also, it is COMMA now. Can we please do something about this? I am not >> > calling for "USER PRI" as Bruce had suggested, but "USERNAME PRI" is just >> > about right. >> >> FWIW I have not forgotten about this. I am planning on completely >> rewriting how the header, and data, get displayed so its low my >> priority (pun intended) list to fix this specific case until then. > > Great! Looking forward to improvements. top(1) should be neat(TM). > Take your time Eitan, it's not that urgent. What do y'all think of https://reviews.freebsd.org/D15801 ? It changes the username length to 8 unconditionally. Its rolled into a rewrite of how the header gets created in order to actually make it understandable. -- Eitan Adler Source, Ports, Doc committer Bugmeister, Ports Security teams