From owner-freebsd-current@FreeBSD.ORG Sun Jan 24 10:58:15 2010 Return-Path: Delivered-To: current@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 164701065670; Sun, 24 Jan 2010 10:58:15 +0000 (UTC) (envelope-from gabor@FreeBSD.org) Received: from server.mypc.hu (server.mypc.hu [87.229.73.95]) by mx1.freebsd.org (Postfix) with ESMTP id BB9A88FC15; Sun, 24 Jan 2010 10:58:14 +0000 (UTC) Received: from server.mypc.hu (localhost [127.0.0.1]) by server.mypc.hu (Postfix) with ESMTP id 78CCC14DA36C; Sun, 24 Jan 2010 11:58:12 +0100 (CET) X-Virus-Scanned: amavisd-new at server.mypc.hu Received: from server.mypc.hu ([127.0.0.1]) by server.mypc.hu (server.mypc.hu [127.0.0.1]) (amavisd-new, port 10024) with LMTP id iiFw-PQ6rvVA; Sun, 24 Jan 2010 11:58:02 +0100 (CET) Received: from [192.168.1.105] (catv-89-132-179-104.catv.broadband.hu [89.132.179.104]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by server.mypc.hu (Postfix) with ESMTPSA id A757D14DA313; Sun, 24 Jan 2010 11:58:02 +0100 (CET) Message-ID: <4B5C27B9.1080805@FreeBSD.org> Date: Sun, 24 Jan 2010 11:58:01 +0100 From: Gabor Kovesdan User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.2; es-ES; rv:1.9.1.5) Gecko/20091204 Thunderbird/3.0 MIME-Version: 1.0 To: Peter Jeremy References: <20100119212019.GL59590@deviant.kiev.zoral.com.ua> <4B56CACF.50508@FreeBSD.org> <4B5B4F4B.3030201@FreeBSD.org> <20100124091911.GI31243@server.vk2pj.dyndns.org> In-Reply-To: <20100124091911.GI31243@server.vk2pj.dyndns.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit Cc: Kostik Belousov , attilio@FreeBSD.org, Hajimu UMEMOTO , current@FreeBSD.org Subject: Re: NLS/strerror efficiency X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 24 Jan 2010 10:58:15 -0000 El 2010. 01. 24. 10:19, Peter Jeremy escribió: > I think this is a good start but still needs some work. One issue is > that the patch mixes whitespace changes (some not complying with > style(9)) and functional changes. This makes it harder to see the > functional changes. > I thought fixing up some style(9) nits was ok but I meant them to be compliant with style(9). Could you please point out, which are not compliant? Shall I revert the style(9) changes for now? > How much of an issue is this in reality? There are two cases to > consider: > 1) A process that dynamically changes its locale. > 2) Locale files being updated whilst the process is running. > > The first can be worked around by also caching the current locale > and checking that it hasn't changed. > I'll fix up my patch to do that. > The second is more problematic - particularly for long-running > programs. Maybe add a timestamp and re-check every minute or 5. > I agree, that it should track changing catalogs but do we really want that? Catalogs are usually bundled with third-party apps and if you update something you obviously want to restart that. And in the case of strerror(3), catalogs are supposed to be updated with libc and when you update libc you probably want to restart everything. -- Gabor Kovesdan FreeBSD Volunteer EMAIL: gabor@FreeBSD.org .:|:. gabor@kovesdan.org WEB: http://people.FreeBSD.org/~gabor .:|:. http://kovesdan.org