From owner-svn-src-head@freebsd.org Thu May 12 20:58:25 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5D02EB39DB8; Thu, 12 May 2016 20:58:25 +0000 (UTC) (envelope-from loos.br@gmail.com) Received: from mail-lb0-x244.google.com (mail-lb0-x244.google.com [IPv6:2a00:1450:4010:c04::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id CB2FA1BA6; Thu, 12 May 2016 20:58:24 +0000 (UTC) (envelope-from loos.br@gmail.com) Received: by mail-lb0-x244.google.com with SMTP id qf3so2203637lbb.0; Thu, 12 May 2016 13:58:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=rU/i+uIHs7TuGOLXXiKFB0joUV84vRPosxrFAJgWzkk=; b=r4G4EcjKqIadt4KLNGqIkrR9V9QRC1rDI07enTzw7KWhI0HV0g6U/YlormgSpEubzb FkGNI+2tUTkfweIFVOS/BBRbdPB1tk/RLP+EpcI/SJO5xHKOP5QJKqopoyOCBeQ0AsVa eRaulJTYVwHkJBYr56buuQV7+pAIY6XAC6MZJEeTV7l2VD4Q364FxMtR9NE7XYRDJ7nY lMIPdXAA4escEluV7vaqd3y4DtrRnlItm31Q0baOgTBhpVOJpcmUoIJ/jSY9l33grHCo DmX69mBocHSg8Zjj9E+HItxIwrYoa7qrFIhAOTqlPn4Fkuih50PTawOcggfTBWTh5aOO TV8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=rU/i+uIHs7TuGOLXXiKFB0joUV84vRPosxrFAJgWzkk=; b=dt2Ztx1RWaEhGsP6XXXEWhsBLK3OA10485+V5M4/qg+RJAPbyvQqmj8wwlBiUvwFeO gjbhhpST2NvpIlMxU1qvlhSLGuLM/K+bRexx0s2WfoD5uuCfJfn5+LZiK3nMq9LGtG02 2AuVq6h7+UBARX2BjZfMuR/IAJ94GVeg3LkoOvHK0AWpwFaLj0bHrxVYITW6sCAwgwf2 rnAXXtgW/OQLQ59KI/hIPmWRcdg3hjhs5gVwV+JRbP92bwkQOQ20vS/1o81khdsLVaYp NmXB/kJXs4jluLNlXfResfqB1RQv0LU9UPH6s0aVyO5UlaeXOHYnKVR9gipVp1+W2soX BViA== X-Gm-Message-State: AOPr4FUccahtcKUy2RIjy9MDJ5Xv6LxKbAJBLpx0AVMTYOk0qP9F4kAiK3EPxjhnFL6fmJK5G8b+4cld4aDuXw== MIME-Version: 1.0 X-Received: by 10.112.189.1 with SMTP id ge1mr5217807lbc.9.1463086702958; Thu, 12 May 2016 13:58:22 -0700 (PDT) Received: by 10.112.73.236 with HTTP; Thu, 12 May 2016 13:58:22 -0700 (PDT) In-Reply-To: <1463085629.1180.75.camel@freebsd.org> References: <201605122012.u4CKCkVD040893@repo.freebsd.org> <1463085629.1180.75.camel@freebsd.org> Date: Thu, 12 May 2016 17:58:22 -0300 Message-ID: Subject: Re: svn commit: r299563 - head/sys/dev/gpio From: Luiz Otavio O Souza To: Ian Lepore Cc: Oleksandr Tymoshenko , src-committers , svn-src-all , svn-src-head Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 May 2016 20:58:25 -0000 On Thu, May 12, 2016 at 5:40 PM, Ian Lepore wrote: > On Thu, 2016-05-12 at 20:12 +0000, Oleksandr Tymoshenko wrote: >> Author: gonzo >> Date: Thu May 12 20:12:45 2016 >> New Revision: 299563 >> URL: https://svnweb.freebsd.org/changeset/base/299563 >> >> Log: >> Add gpiobus_release_pin function to release mapped pin >> >> Add gpiobus_release_pin as a counterpart for gpiobus_map_pin. >> Without it >> it's impossible to properly release pin so if kernel module is >> reloaded >> it can't re-use pins again > > This reminds me that we (Michael Meloun & I) had talked on irc about > renaming gpiobus_map_pin() to gpiobus_acquire_pin() and adding a > release function. Now we have the release, but its name really doesn't > scream that it's the inverse of map_pin. Is it too late to rename map > to acquire? (I'm not too wed to the 'acquire' name, 'allocate' would > also be a good candidate. We also considered 'reserve' but that had > less of a "now I own it exclusively" feel to it. 'map' didn't feel > quite right because mapping pins in an FDT world is the responsibility > of the pinmux driver, not a gpio thing.) I don't think it is too late for this change, actually I think we are right on time to fill the gaps (just another term to 'fix my bugs'...). Luiz