Date: Fri, 27 May 2016 03:07:11 +0000 From: Glen Barber <gjb@FreeBSD.org> To: Ngie Cooper <yaneurabeya@gmail.com> Cc: Allan Jude <allanjude@freebsd.org>, "Conrad E. Meyer" <cem@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r300773 - in head/sys: crypto crypto/aesni crypto/sha2 crypto/siphash kern sys Message-ID: <20160527030711.GZ3335@FreeBSD.org> In-Reply-To: <CAGHfRMA4y_7NAe4ZiZaCOaKxq7tsNz%2BSjaMJX%2BP5Aox=r%2BMJ7w@mail.gmail.com> References: <201605261929.u4QJTTV5085421@repo.freebsd.org> <0f2c3d10-d2dd-3f76-982f-91fbeeb5f3db@freebsd.org> <CAGHfRMA4y_7NAe4ZiZaCOaKxq7tsNz%2BSjaMJX%2BP5Aox=r%2BMJ7w@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--qJ1PC0yZrEAstpRC Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, May 26, 2016 at 08:04:56PM -0700, Ngie Cooper wrote: > On Thu, May 26, 2016 at 7:35 PM, Allan Jude <allanjude@freebsd.org> wrote: > > On 2016-05-26 15:29, Conrad E. Meyer wrote: > >> Author: cem > >> Date: Thu May 26 19:29:29 2016 > >> New Revision: 300773 > >> URL: https://svnweb.freebsd.org/changeset/base/300773 > >> > >> Log: > >> crypto routines: Hint minimum buffer sizes to the compiler > >> > >> Use the C99 'static' keyword to hint to the compiler IVs and output = digest > >> sizes. The keyword informs the compiler of the minimum valid size f= or a given > >> array. Obviously not every pointer can be validated (i.e., the comp= iler can > >> produce false negative but not false positive reports). > >> > >> No functional change. No ABI change. > >> > >> Sponsored by: EMC / Isilon Storage Division >=20 > ... >=20 > > This seems to have broken on sparc64, and other gcc based arches: > > > > =3D=3D=3D> lib/libc (obj,all,install) > > In file included from /usr/src/lib/libc/../libmd/md5.h:40, > > from /usr/src/lib/libc/../libmd/md5c.c:42: > > /usr/obj/sparc64.sparc64/usr/src/tmp/usr/include/sys/md5.h:47: > > error: static or type qualifiers in abstract declarator > > --- md5c.o --- > > *** [md5c.o] Error code 1 >=20 > I was wondering about that in the original commit. It might be a good > idea to revert both commits and reintroduce them with another keyword > (i.e. __static, or something in sys/cdefs.h ) > Thanks, >=20 Conrad is working on a fix for gcc at the moment. I'll be patiently impatient long enough to see how quickly this can be properly fixed. FWIW. Glen --qJ1PC0yZrEAstpRC Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXR7nfAAoJEAMUWKVHj+KTxLgP/0bn7Ek153TAdQCJ0LH4r6fu xjII2BGx/qYRLNbt5ESWDLxFyzjGjk9X76H+v/oKBmI12rOnqFxFhHflur4c4jpD X9VTHnQ7r9cGK5SY5Gh3Pvra8zoCDfSWREVVbrrOyEb2nvdnUeKbJt5qSMvECfSu kmanLtBWOTt79HQNlujIpX4TIESrcHH4eJB7YFI5N+5zfarKyWE/YZ76fGigbYez qLCUqdcF8KjMpindUQ5ujdtTU8mS5n1LuCySssDmJmoSplB/taO7OPzMZvorh5Io uTkACG/CTZYXwCt9ThdwatYtYJjnMUi1VXhfdn5GkB5yjqEVOz5/wk8Qh+m8aejs gqIarJBMTtiGztqGg/Wcf20SkCaogBmxSpPv8lStsnBgFfKbMIKOg8IkaBn0jAs8 FJjEMgWH5UXZsSTN7seR9d7W8HCoGj+RiZvyGSCILCxi6Np8SArAgdIjF82SUtn4 lej9tso3h8pLA5YT+6RTlYhPCTwRr7PGq/4ShSNSSkaZwyVrqV1pFZMWvA9h4uS4 yS+8helX3GnRtJHcCRX8S8+F5vPPUT3Jy6XF6y0XVl/GWMJhflqu9aYonIhkdmLm kTwehkicvB7XMJM+qd2os8KZIT8VlKHzaxqVU1rAxWhr9oZrec7iNUvToCnAwAtL vz6B+gA+iqpsVtQhP68H =0tn1 -----END PGP SIGNATURE----- --qJ1PC0yZrEAstpRC--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20160527030711.GZ3335>