Date: Tue, 08 Feb 2011 19:29:58 +0300 From: Ruslan Mahmatkhanov <cvs-src@yandex.ru> To: arrowdodger <6yearold@gmail.com> Cc: freebsd-ports@freebsd.org Subject: Re: Request for new port review: TortoiseHG. Message-ID: <4D516F86.60200@yandex.ru> In-Reply-To: <AANLkTimYwx-cftRR0yzpSX7JeE49rd0kbniinS%2BC-=WZ@mail.gmail.com> References: <AANLkTin%2BCskJf8vP9iZwRvtC%2B66F%2BD6VPr6JbbO4v6pT@mail.gmail.com> <4D513F7D.1040107@yandex.ru> <AANLkTimYwx-cftRR0yzpSX7JeE49rd0kbniinS%2BC-=WZ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
08.02.2011 16:29, arrowdodger пишет:
> On Tue, Feb 8, 2011 at 4:05 PM, Ruslan Mahmatkhanov<cvs-src@yandex.ru>wrote:
>
>> It shouldn't be listed in pkg-plist, because it will be removed
>> automatically on port deinstall.
>
> Well, if i 'make PREFIX=/home/arr/prefix install&& make
> PREFIX=/home/arr/prefix deinstall' then this file is not deleted. You mean,
> it will be deleted if i install port without PREFIX?
I can't say anything about custom ${PREFIX}, but it definitelly works
for default ${PREFIX} (/usr/local)
>
> dirrm's for lib/nautilus and it's subdirectories should be dirrmtry's
>> actually, because it's doesn't created by tortoisehg-hgtk, but nautilus or
>> nautilus-plugins.
>
> Okay.
>
> Also consider to use:
>>
>> USE_GETTEXT= yes
>> INSTALLS_ICONS= yes
>>
>> In port's Makefile.
>>
> Should it be
> .if !defined(WITHOUT_NLS)
> USE_GETTEXT= yes
> .endif
> ?
Yes.
>
> And what's the purpose of INSTALLS_ICONS?
I can't find description in porters handbook, i believe it was there
some time ago. It's needed for indicate that your ports installs some
icons :)
>
> BLDDIR is defined but seems not used in Makefile. What it is for?
>>
> Oh, this is not needed now. I will remove that.
>
> Спасибо за подсказки.
Пожалуйста :)
--
Regards,
Ruslan
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4D516F86.60200>