From owner-freebsd-ports@FreeBSD.ORG  Tue Feb  8 16:31:18 2011
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: freebsd-ports@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id BB023106566B
	for <freebsd-ports@freebsd.org>; Tue,  8 Feb 2011 16:31:18 +0000 (UTC)
	(envelope-from cvs-src@yandex.ru)
Received: from forward14.mail.yandex.net (forward14.mail.yandex.net
	[95.108.130.92])
	by mx1.freebsd.org (Postfix) with ESMTP id 69A6C8FC17
	for <freebsd-ports@freebsd.org>; Tue,  8 Feb 2011 16:31:18 +0000 (UTC)
Received: from smtp13.mail.yandex.net (smtp13.mail.yandex.net [95.108.130.68])
	by forward14.mail.yandex.net (Yandex) with ESMTP id 7FE4130D065F;
	Tue,  8 Feb 2011 19:31:15 +0300 (MSK)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail;
	t=1297182675; bh=oIrpoiGQqxG3QW1w+TSiSTXoz7WHAszsYxZOvLtp7ZI=;
	h=Message-ID:Date:From:MIME-Version:To:CC:Subject:References:
	In-Reply-To:Content-Type:Content-Transfer-Encoding;
	b=OGt1ljQf/9ISbZRFIwR5hhDu/GcY+0zqeGn+qdU4VO/qcKVMp9MkIJUO/qrpRs5lU
	NVvHPRMYYp3GpZ1oTdM8xbbeVj2IWjz1mlYOIZawonDuuE9+melYCsU2pQvMZ38pHt
	Nd/Tz2GD65slbAc0cyRDQYzeXCQaV8LpX4jKzXOk=
Received: from smeshariki2.local (unknown [213.27.65.65])
	by smtp13.mail.yandex.net (Yandex) with ESMTPSA id 39FED389809D;
	Tue,  8 Feb 2011 19:31:15 +0300 (MSK)
Message-ID: <4D516F86.60200@yandex.ru>
Date: Tue, 08 Feb 2011 19:29:58 +0300
From: Ruslan Mahmatkhanov <cvs-src@yandex.ru>
User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; ru-RU;
	rv:1.9.2.13) Gecko/20110106 Thunderbird/3.1.7
MIME-Version: 1.0
To: arrowdodger <6yearold@gmail.com>
References: <AANLkTin+CskJf8vP9iZwRvtC+66F+D6VPr6JbbO4v6pT@mail.gmail.com>	<4D513F7D.1040107@yandex.ru>
	<AANLkTimYwx-cftRR0yzpSX7JeE49rd0kbniinS+C-=WZ@mail.gmail.com>
In-Reply-To: <AANLkTimYwx-cftRR0yzpSX7JeE49rd0kbniinS+C-=WZ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Cc: freebsd-ports@freebsd.org
Subject: Re: Request for new port review: TortoiseHG.
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 08 Feb 2011 16:31:18 -0000

08.02.2011 16:29, arrowdodger пишет:
> On Tue, Feb 8, 2011 at 4:05 PM, Ruslan Mahmatkhanov<cvs-src@yandex.ru>wrote:
>
>> It shouldn't be listed in pkg-plist, because it will be removed
>> automatically on port deinstall.
>
> Well, if i 'make PREFIX=/home/arr/prefix install&&  make
> PREFIX=/home/arr/prefix deinstall' then this file is not deleted. You mean,
> it will be deleted if i install port without PREFIX?

I can't say anything about custom ${PREFIX}, but it definitelly works 
for default ${PREFIX} (/usr/local)

>
> dirrm's for lib/nautilus and it's subdirectories should be dirrmtry's
>> actually, because it's doesn't created by tortoisehg-hgtk, but nautilus or
>> nautilus-plugins.
>
> Okay.
>
> Also consider to use:
>>
>> USE_GETTEXT=    yes
>> INSTALLS_ICONS= yes
>>
>> In port's Makefile.
>>
> Should it be
> .if !defined(WITHOUT_NLS)
> USE_GETTEXT=    yes
> .endif
> ?

Yes.

>
> And what's the purpose of INSTALLS_ICONS?

I can't find description in porters handbook, i believe it was there 
some time ago. It's needed for indicate that your ports installs some 
icons :)

>
> BLDDIR is defined but seems not used in Makefile. What it is for?
>>
> Oh, this is not needed now. I will remove that.
>
> Спасибо за подсказки.

Пожалуйста :)

-- 
Regards,
Ruslan