From owner-svn-src-all@FreeBSD.ORG Mon Dec 31 14:33:03 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 03EAB791; Mon, 31 Dec 2012 14:33:03 +0000 (UTC) (envelope-from nwhitehorn@freebsd.org) Received: from adsum.doit.wisc.edu (adsum.doit.wisc.edu [144.92.197.210]) by mx1.freebsd.org (Postfix) with ESMTP id BDBD68FC0C; Mon, 31 Dec 2012 14:33:02 +0000 (UTC) MIME-version: 1.0 Content-transfer-encoding: 7BIT Content-type: text/plain; CHARSET=US-ASCII Received: from avs-daemon.smtpauth1.wiscmail.wisc.edu by smtpauth1.wiscmail.wisc.edu (Sun Java(tm) System Messaging Server 7u2-7.05 32bit (built Jul 30 2009)) id <0MFW00F00GF2QA00@smtpauth1.wiscmail.wisc.edu>; Mon, 31 Dec 2012 08:33:02 -0600 (CST) Received: from wanderer.tachypleus.net (pool-72-66-126-15.washdc.fios.verizon.net [72.66.126.15]) by smtpauth1.wiscmail.wisc.edu (Sun Java(tm) System Messaging Server 7u2-7.05 32bit (built Jul 30 2009)) with ESMTPSA id <0MFW008FCGEZ2A20@smtpauth1.wiscmail.wisc.edu>; Mon, 31 Dec 2012 08:33:01 -0600 (CST) Date: Mon, 31 Dec 2012 09:32:59 -0500 From: Nathan Whitehorn Subject: Re: svn commit: r244865 - in head: . lib lib/libdisk share/mk In-reply-to: Sender: whitehorn@wisc.edu To: Juli Mallett Message-id: <50E1A21B.5060008@freebsd.org> X-Spam-Report: AuthenticatedSender=yes, SenderIP=72.66.126.15 X-Spam-PmxInfo: Server=avs-16, Version=5.6.1.2065439, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2012.12.31.142119, SenderIP=72.66.126.15 References: <201212301628.qBUGS6tE037193@svn.freebsd.org> User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:17.0) Gecko/17.0 Thunderbird/17.0 Cc: svn-src-head@freebsd.org, Adrian Chadd , freebsd-current , src-committers@freebsd.org, svn-src-all@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Dec 2012 14:33:03 -0000 On 12/31/12 00:18, Juli Mallett wrote: > On Sun, Dec 30, 2012 at 6:54 PM, Adrian Chadd wrote: >> .. not that I mind old things being retired, but we really should >> announce things like this. >> >> Also - you disconnected libftpio too; is that intentional? > I would assume so, given that this only removed the static library > name, which nothing else could be using still, seeing as how the > library was disconnected and removed in r225952. > >> Just because libdisk/libftpio isn't used by anything in the base -HEAD >> doesn't mean that: >> >> * it's not used by third party programs in ports; >> * it's not used by any external, non open source utilities that people >> have read. >> >> So I'd suggest creating a port for them both and begin the process of >> deprecating the kernel side interfaces that are unique to this API. > Pretty sure the addition of and widespread use of GEOM things > initiated the deprecation of the really lousy and properly-disliked > kernel interfaces involved. > On a similar note, I am extremely doubtful that any external code used libdisk. It was basically an internal detail of sysinstall with an interface that hadn't worked properly for a lot of applications in a very long time. The only evidence I can find that anyone used it for anything in the last decade is bug reports related to how it makes sysinstall crash in even slightly unusual circumstances. That said, I'm perfectly happy to add it back or make a port or something, but I'd prefer some evidence that it was ever used outside of sysinstall before doing that. I think some of the kernel interfaces (kern.geom.conftxt, for instance) have ended up being used in various shell scripts and so should probably stay. -Nathan -Nathan