From owner-freebsd-ports-bugs@FreeBSD.ORG  Thu Aug 28 10:54:04 2014
Return-Path: <owner-freebsd-ports-bugs@FreeBSD.ORG>
Delivered-To: freebsd-ports-bugs@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 7337B404
 for <freebsd-ports-bugs@FreeBSD.org>; Thu, 28 Aug 2014 10:54:04 +0000 (UTC)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 5858111D5
 for <freebsd-ports-bugs@FreeBSD.org>; Thu, 28 Aug 2014 10:54:04 +0000 (UTC)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id s7SAs4Dg064585
 for <freebsd-ports-bugs@FreeBSD.org>; Thu, 28 Aug 2014 10:54:04 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-ports-bugs@FreeBSD.org
Subject: [Bug 193061] stage-fy japanese/eijiro-fpw
Date: Thu, 28 Aug 2014 10:54:04 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Ports Tree
X-Bugzilla-Component: Individual Port(s)
X-Bugzilla-Version: Latest
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: Affects Many People
X-Bugzilla-Who: marino@FreeBSD.org
X-Bugzilla-Status: Needs Triage
X-Bugzilla-Priority: Normal
X-Bugzilla-Assigned-To: freebsd-ports-bugs@FreeBSD.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-193061-13-2RrQrBZc19@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-193061-13@https.bugs.freebsd.org/bugzilla/>
References: <bug-193061-13@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-ports-bugs>, 
 <mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs/>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
 <mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 28 Aug 2014 10:54:04 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=193061

--- Comment #8 from John Marino <marino@FreeBSD.org> ---
(In reply to turutani from comment #7)
> I do not know about this...
> As far as I know, some versions of CD-ROM are sold.
> At least one of them (which I have) contains compressed data with 
> self-extracting lha archive file, having .exe suffix.


Okay, I looked closer and it's trying to handle both cases (either compressed,
or uncompressed eijiro52.txt.

Let's just make this Makefile simpler:
A) Make lha an unconditional EXTRACT_DEPENDS, and move it where the first
EXTRACT_DEPENDS is defined.

B) Get rid of ${CDROM_PATH} completely as well as the DIST_ARCHIVE check


the SRCFILE is always going to end up in WRKDIR directory, so change
MAKE_ARGS+= SRCFILE=${WRKDIR}/${SRCFILE}

Then we can leave the post-extract target mostly how it is now. [1]
Doing it this way makes it simpler, removes the shell command, and the only
downside is an unused dependency on lha in the case of an uncompresses source
file, but that's not a big penalty, right?


what do you think?


[1] I think "-f ${CDROM_PATH}.." changes to "-f ${DICT_pATH}.." and on the next
line "-f ${DICT_PATH}/${SRCFILE}" changes to "-f ${WRKDIR}/${SRCFILE}"

-- 
You are receiving this mail because:
You are the assignee for the bug.