Date: Wed, 23 Apr 2008 14:13:57 -0400 From: Joe Marcus Clarke <marcus@FreeBSD.org> To: Coleman Kane <cokane@FreeBSD.org> Cc: gnome@FreeBSD.org, Sam Leffler <sam@FreeBSD.org> Subject: Re: Update to net/gnome-netstatus to support new wlan system in -CURRENT Message-ID: <1208974437.24487.41.camel@shumai.marcuscom.com> In-Reply-To: <1208973873.6154.31.camel@localhost> References: <1208971129.6154.13.camel@localhost> <1208971281.6154.18.camel@localhost> <480F735A.4080001@freebsd.org> <1208972527.6154.24.camel@localhost> <480F7607.5050004@freebsd.org> <1208973873.6154.31.camel@localhost>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-BTjMEVHPkQpmBKb5Sauk Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Wed, 2008-04-23 at 14:04 -0400, Coleman Kane wrote: > On Wed, 2008-04-23 at 10:46 -0700, Sam Leffler wrote: > > Coleman Kane wrote: > > > On Wed, 2008-04-23 at 10:35 -0700, Sam Leffler wrote: > > > =20 > > >> Coleman Kane wrote: > > >> =20 > > >>> On Wed, 2008-04-23 at 13:18 -0400, Coleman Kane wrote: > > >>> =20 > > >>> =20 > > >>>> Hi, > > >>>> > > >>>> I put together some changes to the net/gnome-netstatus applet to a= llow > > >>>> it to detect and work with the new wlan interface system that was = just > > >>>> introduced in CURRENT. > > >>>> > > >>>> This new code doesn't identify non-wlanN interfaces as wifi anymor= e. > > >>>> > > >>>> I think it may need some help in getting signal-strength detection > > >>>> properly using the if_ndis driver. Mine keeps telling me that the = signal > > >>>> strength is always 100% no matter where I walk in my apt. > > >>>> > > >>>> =20 > > >>>> =20 > > >>> Yes, I do mean to actually attach the patch too. > > >>> > > >>> =20 > > >>> =20 > > >> As I told you previously keying off the ifnet name is a mistake. Wh= at=20 > > >> you can do is check the media status and for any 802.3 interface loo= k=20 > > >> for a backpointer in the MIB to a parent device that must be marked = as=20 > > >> an 802.11 device. Right now this can be defeated if ifnet is rename= d=20 > > >> such that you cannot identify the wlanX unity # to find the MIB entr= y=20 > > >> under net.wlan.X.%parent. > > >> > > >> Separately you appear to have added "an", "rum", and "ray". I'm not= =20 > > >> sure what this code does but again using ifnet names is a mistake. = In=20 > > >> 7.x you can do a similar search of the net.wlan.X MIB space using th= e=20 > > >> %parent backpointer to identify an 802.11 device. wlandebug.c has c= rude=20 > > >> code you can crib (for 7.x). > > >> > > >> I don't recall if 6.x has the backpointer in the MIB namespace to us= e. > > >> > > >> Sam > > >> > > >> =20 > > > > > > The original code was written this way, so I was just mimicking it. Y= our > > > idea sounds a lot more stable. The addition of the "rum" and "ray" > > > interfaces is done by the original patch, as the upstream GNOME code > > > hadn't been written to expect either of those yet. The "an" device is= n't > > > added, it's part of the surrounding text of the patch. You're looking= at > > > a patch-of-a-patch... > > > > > > Anyhow, I'm not the original author but these changes probably make i= t > > > better now than it was before (and my netstatus applet works now). I'= ll > > > see if I can find some time to re-implement this properly over the > > > weekend. We might be able to get more iface info in there as well. > > > > > > =20 > > Ok, thanks. FWIW there is a large body of 802.11-related code that=20 > > should be lifted form various parts of the src tree into a lib80211 or=20 > > similar. For example there is now an XML database of regulatory domain= =20 > > information that ifconfig uses. UI apps could easily want to use this=20 > > info along w/ many other bits that are mostly used by ifconfig at the=20 > > moment. > >=20 > > I am happy to work w/ anyone that's interested in this. > >=20 > > Sam > >=20 >=20 > Sam, >=20 > Maybe this would be a better application of my time... >=20 > I'll start looking into it this weekend...dump some info onto > wiki.freebsd.org....etc... >=20 > Then port gnome-netstatus to that in some manner (while preserving prior > compatibility). >=20 > I still recommend applying my changes to the port in the meantime, as it > will ensure that current users aren't twiddling their thumbs on a > now-broken applet. Thanks for doing this. g-n-s was on my TODO list after seeing the vap changes in -CURRENT. At the time the patch was originally created (back in the 5.X days I believe), I only had an aironet device, and keying off device name was easiest. It would definitely be better to modernize this code. You have permission to commit this patch in the time being. Joe >=20 --=20 Joe Marcus Clarke FreeBSD GNOME Team :: gnome@FreeBSD.org FreeNode / #freebsd-gnome http://www.FreeBSD.org/gnome --=-BTjMEVHPkQpmBKb5Sauk Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.8 (FreeBSD) iEYEABECAAYFAkgPfGUACgkQb2iPiv4Uz4dpZwCggKYZHh667P8TDXXqxTUKte97 WPoAoIqXDy3P0Jby1KfMqaMsmK8wese4 =RoSy -----END PGP SIGNATURE----- --=-BTjMEVHPkQpmBKb5Sauk--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1208974437.24487.41.camel>