Date: Thu, 14 Mar 2019 18:50:43 +0100 From: =?UTF-8?B?VMSzbA==?= Coosemans <tijl@FreeBSD.org> To: Adam Weinberger <adamw@adamw.org> Cc: Koichiro Iwao <meta@freebsd.org>, ports@freebsd.org Subject: Re: loose dependency Message-ID: <20190314185043.4e566819@kalimero.tijl.coosemans.org> In-Reply-To: <CAP7rwcgv0TGpkKcUQcGw_Vv-ONe%2BemXk9BWzR_dg%2BgUN2vGTPA@mail.gmail.com> References: <20190314.134014.2127053084940820202.hrs@allbsd.org> <20190314061242.ixvtakqiel4aa4r3@icepick.vmeta.jp> <20190314062217.3wx3h2hp74mo3zja@icepick.vmeta.jp> <20190314.165018.2032001534188262193.hrs@allbsd.org> <20190314100939.lsbmlua5hps5mdia@icepick.vmeta.jp> <20190314143330.2cc6bc8d@kalimero.tijl.coosemans.org> <20190314164134.nvafkejhmljsacep@icepick.vmeta.jp> <CAP7rwcgv0TGpkKcUQcGw_Vv-ONe%2BemXk9BWzR_dg%2BgUN2vGTPA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 14 Mar 2019 11:20:09 -0600 Adam Weinberger <adamw@adamw.org> wrote: > On Thu, Mar 14, 2019 at 10:41 AM Koichiro Iwao <meta@freebsd.org> wrote: >> On Thu, Mar 14, 2019 at 02:33:30PM +0100, T=C4=B3l Coosemans wrote: =20 >>> Like hrs already said: since this is a build dependency you can just >>> write: >>> >>> BUILD_DEPENDS=3D convert:graphics/ImageMagick6 >>> >>> This does not install ImageMagick6 if 7 is installed. It will only >>> install 6 if convert does not exist. It is a loose dependency. =20 >> >> I understand now. This is what I wanted. Perfect! >> =20 >>> This is not the case for RUN_DEPENDS because dependencies in a package >>> are currently specified using package names (including version). They >>> would have to be specified using features where multiple packages can >>> then provide a feature. =20 >> >> That's good to know. I'd been thinking the only difference between RUN_ >> and BUILD_DEPENDS is when the dependency is checked. =20 >=20 > This makes building from ports behave differently from pkg. Please, > just make an OPTIONS_SINGLE for it, and default it to the current > version (7), not the old version. You mean building from ports versus poudriere? Poudriere would always select ImageMagick6 with the BUILD_DEPENDS line above, but that's fine. Options aren't a good interface for this because the user can select an option that conflicts with the installed version. It's not really a port option but a system-wide option. If this needs to be configurable for poudriere then an entry should be added to bsd.default-versions.mk. Then the BUILD_DEPENDS line above can become: BUILD_DEPENDS=3D convert:graphics/ImageMagick${IMAGEMAGICK_DEFAULT}
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190314185043.4e566819>