From owner-freebsd-qa@FreeBSD.ORG Tue Feb 28 20:11:12 2006 Return-Path: X-Original-To: freebsd-qa@freebsd.org Delivered-To: freebsd-qa@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2D9B616A420; Tue, 28 Feb 2006 20:11:12 +0000 (GMT) (envelope-from sethk@magnesium.net) Received: from toxic.magnesium.net (toxic.magnesium.net [207.154.84.15]) by mx1.FreeBSD.org (Postfix) with ESMTP id D950943D5D; Tue, 28 Feb 2006 20:11:11 +0000 (GMT) (envelope-from sethk@magnesium.net) Received: by toxic.magnesium.net (Postfix, from userid 1165) id 8A556DA8A0; Tue, 28 Feb 2006 12:11:11 -0800 (PST) Date: Tue, 28 Feb 2006 12:11:11 -0800 From: Seth Kingsley To: John Baldwin Message-ID: <20060228201111.GM2695@mail.meowfishies.com> References: <200602261910.k1QJAAmZ089790@freefall.freebsd.org> <200602281419.53871.jhb@freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="zhtSGe8h3+lMyY1M" Content-Disposition: inline In-Reply-To: <200602281419.53871.jhb@freebsd.org> X-Operating-System: FreeBSD 5.4-STABLE i386 X-GPG-Key-ID: 1024D/5C413B08 X-GPG-Key-Fingerprint: F772 5D24 02B4 D233 90F5 080F 0F50 3298 5C41 3B08 User-Agent: Mutt/1.5.11 Cc: freebsd-qa@freebsd.org Subject: Re: bin/93853: [PATCH]: Add country-specific keymap selection to sysinstall X-BeenThere: freebsd-qa@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: FreeBSD Quality Assurance List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Feb 2006 20:11:12 -0000 --zhtSGe8h3+lMyY1M Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Feb 28, 2006 at 02:19:52PM -0500, John Baldwin wrote: > Hmm, I tried this out. One thing I ran into just running it during multi= user > is that hitting Enter didn't work in the country selection dialog. I had= to > hit 'O' for Ok for some reason. It works if I pick a non-default country > actually, so it's something in the logic for the default country case. H= mm, > I fixed this by fixing dmenuSetCountryVariable() to return DITEM_SUCCESS > rather than void in the DEFAULT_COUNTRY case. That's really odd that it > didn't flag that as a warning. Also, I fixed keymapMenuSelect() to corre= ctly > return a DITEM_* value if VAR_COUNTRY wasn't set (dmenuOpenSimple returns= a > boolean). Finally, I think that this should only popup during installs a= nd > if it is run as non-init it shouldn't pop this menu up (under the assumpt= ion > that in multiuser you've already set the keymap). Yeah, everything you've changed looks good. It occured to me last night as= I was using sysinstall to label a disk that it would be irritating for the country menu to come up post-install. Raising the WARNS to 2 shows that I also missed a restorescr(w) at the end = of configCountry(), and there are some orphaned functions sprinkled about. --=20 Seth Kingsley || sethk@magnesium.net --zhtSGe8h3+lMyY1M Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.2 (FreeBSD) iD8DBQFEBK5fD1AymFxBOwgRAjldAJ9XkQ69Hu+O3k3/7jC5RuQqZYuTrACeMpFu XhtECICThPOCMtAyZaLO8dI= =Tcof -----END PGP SIGNATURE----- --zhtSGe8h3+lMyY1M--