Date: Thu, 25 Jun 2015 20:14:07 +0200 From: Antoine Brodin <antoine@FreeBSD.org> To: Sunpoet Hsieh <sunpoet@sunpoet.net> Cc: "ports-committers@freebsd.org" <ports-committers@freebsd.org>, "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>, "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org> Subject: Re: svn commit: r390588 - in head: net/luasocket textproc/luaexpat Message-ID: <CAALwa8mkWpWCk6tCQqu=j2p8sY3H3RMQPs5_DPF_CaJVuDjzoQ@mail.gmail.com> In-Reply-To: <CAMHz58TiYbRzxX5cBi%2BE9tKGwEn2hkvBwBcTLq11F5tNE8=oVg@mail.gmail.com> References: <201506251653.t5PGrWUb082817@svn.freebsd.org> <CAMHz58TiYbRzxX5cBi%2BE9tKGwEn2hkvBwBcTLq11F5tNE8=oVg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Jun 25, 2015 at 8:06 PM, Sunpoet Hsieh <sunpoet@sunpoet.net> wrote: > On Fri, Jun 26, 2015 at 12:53 AM, Antoine Brodin <antoine@freebsd.org> > wrote: >> >> Author: antoine >> Date: Thu Jun 25 16:53:31 2015 >> New Revision: 390588 >> URL: https://svnweb.freebsd.org/changeset/ports/390588 >> >> Log: >> Switch back to lua 5.1, the two consumers of those ports >> (audio/lua51-mpd >> and net-im/prosody) need it >> >> Pointy hat: sunpoet >> >> Modified: >> head/net/luasocket/Makefile >> head/textproc/luaexpat/Makefile >> >> Modified: head/net/luasocket/Makefile >> >> ============================================================================== >> --- head/net/luasocket/Makefile Thu Jun 25 16:52:55 2015 (r390587) >> +++ head/net/luasocket/Makefile Thu Jun 25 16:53:31 2015 (r390588) >> @@ -16,7 +16,7 @@ GH_ACCOUNT= diegonehab >> GH_TAGNAME= v3.0-rc1 >> >> MAKE_ARGS= LUA_VER=${LUA_VER} >> -USES= lua gmake pkgconfig >> +USES= lua:51 gmake pkgconfig >> >> CFLAGS+= `pkgconf --cflags lua-${LUA_VER}` >> LDFLAGS+= -shared `pkgconf --libs lua-${LUA_VER}` >> >> Modified: head/textproc/luaexpat/Makefile >> >> ============================================================================== >> --- head/textproc/luaexpat/Makefile Thu Jun 25 16:52:55 2015 >> (r390587) >> +++ head/textproc/luaexpat/Makefile Thu Jun 25 16:53:31 2015 >> (r390588) >> @@ -13,7 +13,7 @@ COMMENT= LuaExpat is a SAX XML parser ba >> >> LIB_DEPENDS= libexpat.so:${PORTSDIR}/textproc/expat2 >> >> -USES= gmake lua >> +USES= gmake lua:51 >> ALL_TARGET= lib >> CFLAGS+= -DLUA_INT_LONG >> >> > > Hi, > > Bapt done lots of work to convert USE_LUA to USES=lua. > IIRC, most of them are USES=lua:51. > We need to relax them to USES=lua if they work fine with lua52 or lua53. > > In this case, they build fine with lua52 and lua53. > I think the correct fix should be: > - audio/lua51-mpd: replace USES=lua:51 with USES=lua (and rename this port > to lua-mpd). > - net-im/prosody: replace USES=lua:51 in security/luasec/Makefile with > USES=lua. > > Can you revert this and change USES=lua:51 to USES=lua for audio/lua51-mpd > and security/luasec? I won't revert since it breaks the 2 ports mentioned above. Cheers, Antoine
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAALwa8mkWpWCk6tCQqu=j2p8sY3H3RMQPs5_DPF_CaJVuDjzoQ>