From owner-svn-src-all@freebsd.org  Fri Apr 15 15:40:01 2016
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5807FAED8EA;
 Fri, 15 Apr 2016 15:40:01 +0000 (UTC)
 (envelope-from ronald-lists@klop.ws)
Received: from smarthost1.greenhost.nl (smarthost1.greenhost.nl
 [195.190.28.81]) (using TLSv1 with cipher AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 23E47176A;
 Fri, 15 Apr 2016 15:40:00 +0000 (UTC)
 (envelope-from ronald-lists@klop.ws)
Received: from smtp.greenhost.nl ([213.108.104.138])
 by smarthost1.greenhost.nl with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16)
 (Exim 4.72) (envelope-from <ronald-lists@klop.ws>)
 id 1ar5b7-0004Q5-5t; Fri, 15 Apr 2016 17:23:53 +0200
Content-Type: text/plain; charset=utf-8; format=flowed; delsp=yes
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org, "Warner Losh" <imp@freebsd.org>
Subject: Re: svn commit: r298011 - head/sys/cam/ata
References: <201604142213.u3EMDklN061064@repo.freebsd.org>
Date: Fri, 15 Apr 2016 17:23:47 +0200
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
From: "Ronald Klop" <ronald-lists@klop.ws>
Message-ID: <op.yfyvn9epkndu52@sjakie.klop.ws>
In-Reply-To: <201604142213.u3EMDklN061064@repo.freebsd.org>
User-Agent: Opera Mail/12.16 (FreeBSD)
X-Authenticated-As-Hash: 398f5522cb258ce43cb679602f8cfe8b62a256d1
X-Virus-Scanned: by clamav at smarthost1.samage.net
X-Spam-Level: /
X-Spam-Score: -0.2
X-Spam-Status: No, score=-0.2 required=5.0 tests=ALL_TRUSTED,
 BAYES_50 autolearn=disabled version=3.4.0
X-Scan-Signature: e462de357cb394d64966911c06262bc8
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 15 Apr 2016 15:40:01 -0000

Hello,

Out of curiosity, what are these big problems? Broken device or other  
things (timeouts/triggers/full queues) going on in the kernel?

Regards,
Ronald.


On Fri, 15 Apr 2016 00:13:46 +0200, Warner Losh <imp@freebsd.org> wrote:

> Author: imp
> Date: Thu Apr 14 22:13:46 2016
> New Revision: 298011
> URL: https://svnweb.freebsd.org/changeset/base/298011
> erLog:
>   Add a comment about why the timeout for flush was lowered to 5s.
>
> Modified:
>   head/sys/cam/ata/ata_da.c
>
> Modified: head/sys/cam/ata/ata_da.c
> ==============================================================================
> --- head/sys/cam/ata/ata_da.c	Thu Apr 14 22:13:44 2016	(r298010)
> +++ head/sys/cam/ata/ata_da.c	Thu Apr 14 22:13:46 2016	(r298011)
> @@ -912,6 +912,11 @@ adadump(void *arg, void *virtual, vm_off
>  	if (softc->flags & ADA_FLAG_CAN_FLUSHCACHE) {
>  		xpt_setup_ccb(&ccb.ccb_h, periph->path, CAM_PRIORITY_NORMAL);
> +		/*
> +		 * Tell the drive to flush its intenral cache. if we
> +		 * can't flush in 5s we have big problems. No need to
> +		 * wait the default 60s to detect problems.
> +		 */
>  		ccb.ccb_h.ccb_state = ADA_CCB_DUMP;
>  		cam_fill_ataio(&ccb.ataio,
>  				    0,
> _______________________________________________
> svn-src-all@freebsd.org mailing list
> https://lists.freebsd.org/mailman/listinfo/svn-src-all
> To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"