Date: Wed, 6 Jul 2011 00:00:16 -0700 From: Garrett Cooper <yanegomi@gmail.com> To: Robert Millan <rmh@debian.org> Cc: freebsd-hackers@freebsd.org, Ed Maste <emaste@freebsd.org> Subject: Re: [PATCH] __FreeBSD_kernel__ Message-ID: <CAGH67wQtEpufr5EOFNLdcfOCAadPg1peRvNHd_zFXBNqGYxpqQ@mail.gmail.com> In-Reply-To: <CAOfDtXN_xi-K9z1N%2BA4RPcUbuQmZ7cMgPpf_VCRYPL_gkLUT6w@mail.gmail.com> References: <CAOfDtXPUxQO1zbnxh8sh%2By7g=d8QaH2svYtEQJ06L4d%2BQKG8VA@mail.gmail.com> <20110702193724.5c55a6c9@kan.dnsalias.net> <20110703020827.GA5763@sandvine.com> <CAGH67wQAv4Tf8HjccN2GZzgD2u1ZrORABtGehxXjeg109%2BRNWQ@mail.gmail.com> <20110703103531.4a553271@kan.dnsalias.net> <CAOfDtXOcfbNw6St5CMN4GB_psf8hZEV=hpL4q3mmQXqWeLmqXQ@mail.gmail.com> <20110705140527.17362ed5@kan.dnsalias.net> <20110705201214.GA31647@sandvine.com> <CAOfDtXN_xi-K9z1N%2BA4RPcUbuQmZ7cMgPpf_VCRYPL_gkLUT6w@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Jul 5, 2011 at 11:53 PM, Robert Millan <rmh@debian.org> wrote: > 2011/7/5 Ed Maste <emaste@freebsd.org>: >> On the topic of where such a macro should be defined I originally had >> no strong opinion. =A0However, valid points have been raised about >> compiling software for FreeBSD using compilers that are not the one in >> the base system (from ports or otherwise, and GCC or otherwise). =A0This >> I think is a very valid point and one that would make me lean towards >> defining the macro in sys/param.h. =A0How workable is it to #include >> sys/param.h to pick up the macro where needed? > > That works most of the time. =A0There could be a problem if software > can't assume <sys/param.h> is present, but I think it covers the vast > majority of cases. Speaking from my limited experience trying to fix net-snmp's autoconf tests over the past couple of days and maintaining LTP, as well as development in general on FreeBSD and Linux platforms, I think that more of an issue lays in socializing the development structure of FreeBSD to third-parties, in particular because a number of groups fail to adhere to some of the practices that have been explicitly or implicitly put forth by FreeBSD in terms of headers and definitions. Granted, this is one piece of the puzzle, but it's an important one, because the following (for example): $ cat foo.c #include <sys/types.h> #include <netinet/in.h> #include <netinet/in_pcb.h> #include <sys/param.h> #include <stdio.h> ... isn't guaranteed to work :). Thanks, -Garrett
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGH67wQtEpufr5EOFNLdcfOCAadPg1peRvNHd_zFXBNqGYxpqQ>