From owner-svn-src-head@freebsd.org Sun Sep 4 20:36:18 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CEACCB71034; Sun, 4 Sep 2016 20:36:18 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from tensor.andric.com (tensor.andric.com [IPv6:2001:7b8:3a7:1:2d0:b7ff:fea0:8c26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "tensor.andric.com", Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7C03A938; Sun, 4 Sep 2016 20:36:18 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from [IPv6:2001:7b8:3a7::cc0e:18d9:a9a1:d549] (unknown [IPv6:2001:7b8:3a7:0:cc0e:18d9:a9a1:d549]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id 634BB2F749; Sun, 4 Sep 2016 22:36:15 +0200 (CEST) Subject: Re: svn commit: r305392 - head/sys/conf Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Content-Type: multipart/signed; boundary="Apple-Mail=_1F03A32E-ADC4-4716-B563-D553E7C8610C"; protocol="application/pgp-signature"; micalg=pgp-sha1 X-Pgp-Agent: GPGMail 2.6.1 From: Dimitry Andric In-Reply-To: Date: Sun, 4 Sep 2016 22:36:03 +0200 Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-Id: <000B5E66-D804-4317-9957-8BDEDBD6B7F6@FreeBSD.org> References: <201609041755.u84HtMa5060050@repo.freebsd.org> To: cem@freebsd.org X-Mailer: Apple Mail (2.3124) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 04 Sep 2016 20:36:18 -0000 --Apple-Mail=_1F03A32E-ADC4-4716-B563-D553E7C8610C Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii Not in this particular case, as the section is exclusively meant for clang. Most of these warning options are completely different from gcc's. The gcc related section is just below this part in kern.mk. -Dimitry > On 04 Sep 2016, at 22:03, Conrad Meyer wrote: >=20 > Assuming we'd like to enable building with both compilers for now, > isn't it better to use a form both accept? >=20 > Best, > Conrad >=20 > On Sun, Sep 4, 2016 at 12:31 PM, Dimitry Andric = wrote: >> On 04 Sep 2016, at 20:57, Conrad Meyer wrote: >>>=20 >>> On Sun, Sep 4, 2016 at 10:55 AM, Dimitry Andric = wrote: >>>> Author: dim >>>> Date: Sun Sep 4 17:55:22 2016 >>>> New Revision: 305392 >>>> URL: https://svnweb.freebsd.org/changeset/base/305392 >>>>=20 >>>> Log: >>>> For kernel builds, instead of suppressing certain clang warnings, = make >>>> them non-fatal, so there is some incentive to fix them eventually. >>>>=20 >>>> Modified: >>>> head/sys/conf/kern.mk >>>>=20 >>>> Modified: head/sys/conf/kern.mk >>>> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >>>> --- head/sys/conf/kern.mk Sun Sep 4 17:50:23 2016 = (r305391) >>>> +++ head/sys/conf/kern.mk Sun Sep 4 17:55:22 2016 = (r305392) >>>> @@ -17,13 +17,13 @@ CWARNFLAGS?=3D -Wall -Wredundant-decls = -Wn >>>> # kernel where fixing them is more trouble than it is worth, or = where there is >>>> # a false positive. >>>> .if ${COMPILER_TYPE} =3D=3D "clang" >>>> -NO_WCONSTANT_CONVERSION=3D -Wno-constant-conversion >>>> -NO_WSHIFT_COUNT_NEGATIVE=3D -Wno-shift-count-negative >>>> -NO_WSHIFT_COUNT_OVERFLOW=3D -Wno-shift-count-overflow >>>> -NO_WSELF_ASSIGN=3D -Wno-self-assign >>>> -NO_WUNNEEDED_INTERNAL_DECL=3D = -Wno-unneeded-internal-declaration >>>> +NO_WCONSTANT_CONVERSION=3D -Wno-error-constant-conversion >>>> +NO_WSHIFT_COUNT_NEGATIVE=3D -Wno-error-shift-count-negative >>>> +NO_WSHIFT_COUNT_OVERFLOW=3D -Wno-error-shift-count-overflow >>>> +NO_WSELF_ASSIGN=3D -Wno-error-self-assign >>>> +NO_WUNNEEDED_INTERNAL_DECL=3D = -Wno-error-unneeded-internal-declaration >>>> NO_WSOMETIMES_UNINITIALIZED=3D -Wno-error-sometimes-uninitialized >>>> -NO_WCAST_QUAL=3D -Wno-cast-qual >>>> +NO_WCAST_QUAL=3D -Wno-error-cast-qual >>>=20 >>> I like goal of the change. Shouldn't these be -Wno-error=3Dcast-qual,= >>> etc., though? >>=20 >> That's how gcc spells them. Clang accepts both forms, there is no >> functional difference. >>=20 >> -Dimitry >>=20 --Apple-Mail=_1F03A32E-ADC4-4716-B563-D553E7C8610C Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.30 iEYEARECAAYFAlfMhb4ACgkQsF6jCi4glqPQMACgxdHRlWFuIBabA/Dv2tbiwnod JvwAnRlpczNqvpT0/3ES5XNnRzy24mCh =KuBb -----END PGP SIGNATURE----- --Apple-Mail=_1F03A32E-ADC4-4716-B563-D553E7C8610C--