Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 01 Jun 2015 06:28:53 -0400
From:      John Baldwin <jhb@freebsd.org>
To:        Dimitry Andric <dim@freebsd.org>
Cc:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r283870 - head/sys/amd64/amd64
Message-ID:  <14276941.3c2kAXm4xn@ralph.baldwin.cx>
In-Reply-To: <201506010650.t516oeNY080402@svn.freebsd.org>
References:  <201506010650.t516oeNY080402@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Monday, June 01, 2015 06:50:40 AM Dimitry Andric wrote:
> Author: dim
> Date: Mon Jun  1 06:50:39 2015
> New Revision: 283870
> URL: https://svnweb.freebsd.org/changeset/base/283870
> 
> Log:
>   Remove unneeded NULL checks in amd64's trap_fatal().
>   
>   Since td_name is an array member of struct thread, it can never be NULL,
>   so the check can be removed.  In addition, curproc can never be NULL,
>   so remove the if statement, and splice the two printfs() together.
>   
>   While here, remove the u_long cast, and use the correct printf format
>   specifier curproc->p_pid.
>   
>   Reviewed by:	kib
>   MFC after:	1 week
>   Differential Revision: https://reviews.freebsd.org/D2695

i386 has the curproc check and pid cast (it dates from < 5 when curproc was
NULL when a CPU was idle (we didn't have idle threads)).  Can you fix it as
well?

-- 
John Baldwin



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?14276941.3c2kAXm4xn>