From owner-freebsd-stable@FreeBSD.ORG  Tue Nov 26 12:48:13 2013
Return-Path: <owner-freebsd-stable@FreeBSD.ORG>
Delivered-To: freebsd-stable@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 4DB5BA18
 for <freebsd-stable@freebsd.org>; Tue, 26 Nov 2013 12:48:13 +0000 (UTC)
Received: from isis.morrow.me.uk (isis.morrow.me.uk [204.109.63.142])
 by mx1.freebsd.org (Postfix) with ESMTP id 2A4D12B56
 for <freebsd-stable@freebsd.org>; Tue, 26 Nov 2013 12:48:12 +0000 (UTC)
Received: from anubis.morrow.me.uk
 (host109-145-254-96.range109-145.btcentralplus.com [109.145.254.96])
 (Authenticated sender: mauzo)
 by isis.morrow.me.uk (Postfix) with ESMTPSA id E7E8B4509D
 for <freebsd-stable@freebsd.org>; Tue, 26 Nov 2013 12:48:04 +0000 (UTC)
DKIM-Filter: OpenDKIM Filter v2.8.3 isis.morrow.me.uk E7E8B4509D
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=morrow.me.uk;
 s=dkim201101; t=1385470088;
 bh=zBuQFRybDgR6vwmPhMdv2bQJLqejq7m6snQaw8khuUA=;
 h=Date:From:To:Subject:References:In-Reply-To;
 b=TjUJOv8RULOtPN70nhgCSu8sm8SFyNPz3A+l+72I3gkjYQQ0HxIHGG8a+QcuOGkFh
 10A1BeKvr/Yzdsvn/59Y6oolmLXloJ9IhJX7SeLs9vFpwSBCtNBpOYoBSc3z/yHDWm
 m+y7GWv/QrBmlH9ZXX3xu8rkAwMIviyWEFtwUTz8=
X-Virus-Status: Clean
X-Virus-Scanned: clamav-milter 0.98 at isis.morrow.me.uk
Received: by anubis.morrow.me.uk (Postfix, from userid 5001)
 id 288CDF774; Tue, 26 Nov 2013 12:48:01 +0000 (GMT)
Date: Tue, 26 Nov 2013 12:48:01 +0000
From: Ben Morrow <ben@morrow.me.uk>
To: freebsd-stable@freebsd.org
Subject: Re: ipfw table add problem
Message-ID: <20131126124757.GA9974@anubis.morrow.me.uk>
References: <CAAcX-AGDZbFn5RmhLBBn2PPWRPcsFUnea5MgTc7nuXGD8Ge53A@mail.gmail.com>
 <52911993.8010108@ipfw.ru>
 <CAAcX-AEt_i8RUfmMy6WLnER0X=uLk5A1=oj911k-nyMJEghRLw@mail.gmail.com>
 <529259DE.2040701@FreeBSD.org>
 <20131125152238.S78756@sola.nimnet.asn.au>
 <1385391778.1220.4.camel@revolution.hippie.lan>
 <20131126001806.27951AD3DBF@rock.dv.isc.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5293EBD6.8010009@protected-networks.net>
X-Newsgroups: gmane.os.freebsd.stable
User-Agent: Mutt/1.5.21 (2010-09-15)
X-BeenThere: freebsd-stable@freebsd.org
X-Mailman-Version: 2.1.16
Precedence: list
List-Id: Production branch of FreeBSD source code <freebsd-stable.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-stable>,
 <mailto:freebsd-stable-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-stable/>
List-Post: <mailto:freebsd-stable@freebsd.org>
List-Help: <mailto:freebsd-stable-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>,
 <mailto:freebsd-stable-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 26 Nov 2013 12:48:13 -0000

Quoth Michael Butler <imb@protected-networks.net>:
> 
> Misinterpreting "10.2.3.01" as "0.0.0.10/32" without so much as a
> warning from either inet_pton() or ipfw is an egregious breach of POLA,

That's not a bug in inet_pton, though, that's a bug in ipfw. It's
blindly passing the string to atoi or some such when inet_pton fails,
and ignoring the fact it doesn't consume the whole string.

Ben