Date: Tue, 16 Mar 1999 11:26:18 +1100 (EST) From: Gregory Bond <gnb@itga.com.au> To: FreeBSD-gnats-submit@freebsd.org Subject: i386/10606: Patch: nit with atapi.c and LS-120s Message-ID: <199903160026.LAA14331@hellcat.itga.com.au>
next in thread | raw e-mail | index | archive | help
>Number: 10606
>Category: i386
>Synopsis: Probablue odd error message if LS-120 is not configured
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Mon Mar 15 16:30:01 PST 1999
>Closed-Date:
>Last-Modified:
>Originator: Gregory Bond
>Release: FreeBSD 3.1-STABLE i386
>Organization:
ITG Australia Limited
>Environment:
FreeBSD 3.1-Stable
An LS-120 (or other ATAPI Direct Access device) installed but no wfd
driver configured.
>Description:
While fossicking around the atapi code I noticed that if an LS-120
(or other ATAPI Direct Access device - are there any?) is installed
but the relevent wfd driver is not configured in the kernel, then
the probe code in atapi.c falls through to the CD case. This will
cause the acd driver to try and probe/attach the LS-120, which is
likely to give interesting error messages!
>How-To-Repeat:
Note I have no LS-120 to test this, so I am assuming this is a bug. Inspect
the code and note that in the case WNFD == 0, th switch statement inside
atapi_attach() falls through.
>Fix:
*** ./sys/i386/isa/atapi.c.dist Mon Mar 15 18:30:21 1999
--- ./sys/i386/isa/atapi.c Tue Mar 16 11:15:01 1999
***************
*** 291,296 ****
--- 291,299 ----
ata->attached[unit] = 1;
return (1);
}
+ #else
+ printf ("wdc%d: ATAPI LS-120 (or other DASD) not configured\n",
ctlr);
+ break;
#endif
case AT_TYPE_CDROM: /* CD-ROM device */
#if NACD > 0
>Release-Note:
>Audit-Trail:
>Unformatted:
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199903160026.LAA14331>