From owner-svn-src-all@FreeBSD.ORG Fri Sep 19 18:43:17 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 23ED94C2 for ; Fri, 19 Sep 2014 18:43:17 +0000 (UTC) Received: from mail-qc0-f171.google.com (mail-qc0-f171.google.com [209.85.216.171]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D7204B1F for ; Fri, 19 Sep 2014 18:43:16 +0000 (UTC) Received: by mail-qc0-f171.google.com with SMTP id x3so3598576qcv.16 for ; Fri, 19 Sep 2014 11:43:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=hNfiSpbt+5iJ6mVTJ/RtQVzKRH1VrBZUSMeqWDn6v68=; b=Qv4L6DdPFJ+q6r0Gu3dT9HHH3ubM4SyKuIl4dMF4Al5ezala05pwiQSXMnxRg7sx71 ku1zV/Ref7AOTZmJAexUCdBknZHZ9xKnRQmiZyFsm2xNvWTSNUzAevAYwx3LOwvVyqa8 SiKByCCjro62Q9DOFrHaSV87sZ1pO9T/lPNjEmSPcqQsR3d3nm+ntZdcISRMTyFDBmQB 78pxioC5VE++2AyoWushxLm57vhcxYh7HOMnOkOfNmk/gjBi07isPORkay6SVXMYRShI vhZP0fkGx9lgGlO+pyQAOjFHhHruLcxoK3wDH4MEZhH03YuScweFhz7pJZM636Us9sJM k/jw== X-Gm-Message-State: ALoCoQlbpVpiwgZ1y9jzijhXcXXfDOP5MSGx2KlxHwT6TaYVCseQ+B9WxuODsPWUVIJpyuvt/kWw MIME-Version: 1.0 X-Received: by 10.224.4.72 with SMTP id 8mr2500066qaq.79.1411148135880; Fri, 19 Sep 2014 10:35:35 -0700 (PDT) Received: by 10.140.16.183 with HTTP; Fri, 19 Sep 2014 10:35:35 -0700 (PDT) In-Reply-To: <11362806.9nSfhFyLDg@ralph.baldwin.cx> References: <201409181655.s8IGtgft042984@svn.freebsd.org> <5783417ED470465B9C816FCA02B3690D@multiplay.co.uk> <11362806.9nSfhFyLDg@ralph.baldwin.cx> Date: Fri, 19 Sep 2014 11:35:35 -0600 Message-ID: Subject: Re: svn commit: r271788 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs From: Will Andrews To: John Baldwin Content-Type: text/plain; charset=UTF-8 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, "src-committers@FreeBSD.org" , Steven Hartland X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Sep 2014 18:43:17 -0000 I found that neither TUNABLE_INT nor CTLFLAG_RWTUN work with this particular implementation of the tunable, so there is a regression that needs to be fixed (i.e. vfs.zfs.debug_flags always comes up 0 no matter what's in loader.conf). I believe it's limited to this particular tunable, however, because I tested another SYSCTL_PROC that had CTLFLAG_TUN set and it worked. --Will. On Fri, Sep 19, 2014 at 10:34 AM, John Baldwin wrote: > On Thursday, September 18, 2014 06:37:28 PM Steven Hartland wrote: >> You don't need a seperate TUNABLE_INT declations any more since the >> excellent SYSCTL refactor. > > That is my fault. I wasn't certain if SYSCTL_PROC() would work correctly when > Will asked me on IRC, but it seems it does so long as the tunable type is one > it knows how to parse (e.g. CTLTYPE_INT). If your sysctl wants a "blob" > (CTLTYPE_OPAQUE or the like), then you still need your own tunable fetching > handler. > > -- > John Baldwin