Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 21 Aug 2016 00:50:44 +1000
From:      Kubilay Kocak <koobs@FreeBSD.org>
To:        Alexey Dokuchaev <danfe@FreeBSD.org>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r420508 - head/comms/hylafax
Message-ID:  <ccae17d7-8b84-8727-f5f0-4cee9cef008f@FreeBSD.org>
In-Reply-To: <20160820144244.GA3813@FreeBSD.org>
References:  <201608201241.u7KCfuEk049392@repo.freebsd.org> <20160820144244.GA3813@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 21/08/2016 12:42 AM, Alexey Dokuchaev wrote:
> On Sat, Aug 20, 2016 at 12:41:56PM +0000, Kubilay Kocak wrote:
>> New Revision: 420508 URL:
>> https://svnweb.freebsd.org/changeset/ports/420508
>> 
>> Log: comms/hylafax: Mark Un'BROKEN, Take MAINTAINER'ship
>> 
>> * Mark Un'BROKEN * Take MAINTAINERSHIP
>> 
>> PR:		200922 Requested by:	Dave <dave at ci com au>
> 
> Lack of *any* functional changes to this port (I was wondering why
> port revision was bumped in this case) looks questinable; commit
> message is banal (30/70 rule violation).  Reading the PR just
> confirmed my worries.

On the basis of a user request to unmark the port broken, the change was
reverted and I took maintainership to investigate the issue reports in
more detail. Actual or potential user impact while that occurs is not
warranted or necessary.

I accept the commit log formatting criticisms, they were done hastily.

> ./danfe
> 




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ccae17d7-8b84-8727-f5f0-4cee9cef008f>