From owner-freebsd-fs@freebsd.org Mon Jun 3 21:24:50 2019 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E822315BE82F for ; Mon, 3 Jun 2019 21:24:49 +0000 (UTC) (envelope-from ronald-lists@klop.ws) Received: from smarthost1.greenhost.nl (smarthost1.greenhost.nl [195.190.28.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id CE23D707E7 for ; Mon, 3 Jun 2019 21:24:48 +0000 (UTC) (envelope-from ronald-lists@klop.ws) Received: from smtp.greenhost.nl ([213.108.110.112]) by smarthost1.greenhost.nl with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hXuRa-0002u7-Sl; Mon, 03 Jun 2019 23:24:40 +0200 Content-Type: text/plain; charset=utf-8; format=flowed; delsp=yes To: "freebsd-fs@freebsd.org" , "Rick Macklem" Subject: Re: RFC: should an incremental reload of exports for mountd be optional? References: Date: Mon, 03 Jun 2019 23:24:40 +0200 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: "Ronald Klop" Message-ID: In-Reply-To: User-Agent: Opera Mail/12.16 (FreeBSD) X-Authenticated-As-Hash: 398f5522cb258ce43cb679602f8cfe8b62a256d1 X-Virus-Scanned: by clamav at smarthost1.samage.net X-Spam-Level: -- X-Spam-Score: -2.0 X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED, BAYES_00 autolearn=disabled version=3.4.2 X-Scan-Signature: e462de357cb394d64966911c06262bc8 X-Rspamd-Queue-Id: CE23D707E7 X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; spf=pass (mx1.freebsd.org: domain of ronald-lists@klop.ws designates 195.190.28.88 as permitted sender) smtp.mailfrom=ronald-lists@klop.ws X-Spamd-Result: default: False [-1.68 / 15.00]; TO_DN_EQ_ADDR_SOME(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:195.190.28.64/27]; MX_GOOD(-0.01)[mx2.greenhost.nl,mx1.greenhost.nl]; RCPT_COUNT_TWO(0.00)[2]; NEURAL_HAM_SHORT(-0.42)[-0.419,0]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:47172, ipnet:195.190.28.0/24, country:NL]; SUBJECT_ENDS_QUESTION(1.00)[]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.997,0]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[klop.ws]; TO_MATCH_ENVRCPT_SOME(0.00)[]; IP_SCORE(-0.46)[ip: (-1.48), ipnet: 195.190.28.0/24(-0.46), asn: 47172(-0.36), country: NL(0.01)]; MID_RHS_NOT_FQDN(0.50)[]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[] X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Jun 2019 21:24:50 -0000 On Fri, 31 May 2019 23:50:10 +0200, Rick Macklem wrote: > Hi, > > I have created a patch for PR#237860 that improves the time it takes to > reload > the exports file(s) for an NFS file server from seconds->milliseconds by > only doing > system calls for the changes to the exports file(s). (Assumes each > reload includes > changes to only a small fraction of the entries.) > > I made it a non-default option of "-I", but asomers@ asked why it needed > to be > optional. > > Basically, I made it optional because I felt the patch might still be > buggy and not > handle some case of an exports file change that I missed. > > However, I can see the argument of making it non-optional (or optional > but enabled > by default) so that sysadmins don't need to add "-I" to avoid long > periods where the > nfsd threads are suspended. > If it is broken, the deamon would need to be restarted to do a full > reload, but that > would also be the case if a sysadmin specified the "-I" option. > > So, the question is... "do you think this should be an option or just > always enabled?". always enabled +1 > Thanks , rick > _______________________________________________ > freebsd-fs@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-fs > To unsubscribe, send any mail to "freebsd-fs-unsubscribe@freebsd.org"