From owner-freebsd-x11@freebsd.org Fri Jan 15 08:52:46 2016 Return-Path: Delivered-To: freebsd-x11@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D261DA8341D for ; Fri, 15 Jan 2016 08:52:46 +0000 (UTC) (envelope-from listjm@club-internet.fr) Received: from smtp21.services.sfr.fr (smtp21.services.sfr.fr [93.17.128.2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 6FB162EE8 for ; Fri, 15 Jan 2016 08:52:45 +0000 (UTC) (envelope-from listjm@club-internet.fr) Received: from filter.sfr.fr (localhost [77.195.141.60]) by msfrf2114.sfr.fr (SMTP Server) with ESMTP id E49A8700010F; Fri, 15 Jan 2016 09:52:42 +0100 (CET) Authentication-Results: sfrmc.priv.atos.fr; dkim=none (no signature); dkim-adsp=none (no policy) header.from=listjm@club-internet.fr Received: from [192.168.1.51] (60.141.195.77.rev.sfr.net [77.195.141.60]) by msfrf2114.sfr.fr (SMTP Server) with ESMTP id 880947000069; Fri, 15 Jan 2016 09:52:42 +0100 (CET) X-SFR-UUID: 20160115085242557.880947000069@msfrf2114.sfr.fr Subject: build-able drm-i915-update-38 To: freebsd-x11@freebsd.org, =?iso-8859-1?q?Jean-S=E9bastien_P=E9dron?= From: Juan =?iso-8859-1?b?UmFt824=?= Molina Menor Message-ID: <5698B350.1080509@club-internet.fr> Date: Fri, 15 Jan 2016 09:52:32 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: freebsd-x11@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: X11 on FreeBSD -- maintaining and support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Jan 2016 08:52:46 -0000 > On 13/01/2016 22:43, Nikola Pajkovsky wrote: > >>/I rebuild a full kernel from scratch and it does build fine here. There />>/is no "unused variable" warning for me. Do you build a non-debug kernel />>/perhaps? I don't plan to build-test such a kernel now, I'll do it when />>/the patch is finished. />//>/Oh, everytime? I have found out, that / > I use "make buildkernel -DKERNFAST" so only the modifed files are > recompiled. I just rebuild the kernel from scratch this time to > double-check if I missed a warning. > > >/$ cd sys/modules/drm2 />/$ make -j9 />/$ make DESTDIR=/boot/ KMODDIR=kernel.i915 install />//>/is engough (only after I have fully built and booted kernel) / > Yes, this works fine, but this doesn't use many defaults set by GENERIC, > such as debugging options or 32-bit support on 64-bit archs. > > The problem you hit is likely because I build a debug kernel (the > variable is used) and not you (only the declaration remains). > > >/gen6_ggtt_bind_object() />/const int max_entries = dev_priv->mm.gtt->gtt_total_entries - > first_entry; />/BUG_ON(i > max_entries); />//>/Seems like BUG_ON is noop, which should not be. / > BUG_ON() is a KASSERT() which is defined to nothing on a non-debug > kernel. The variable should be declared in: > > #if defined(INVARIANTS) > ... > #endif > > If you are still willing to send a pull request, you're welcome to do > so! I know the change is small, so if you don't feel like cloning an > entire repository just for that, I understand and I will fix it. > > Unlike what I said in my previous email, the pull request should be > against the drm-i915-update-38 branch. > > -- > Jean-Sébastien Pédron Thanks for the explanation. It certainly explains the issue here, as I’m building a NODEBUG kernel. I’ll test with a GENERIC one. Best regards, Juan