From owner-freebsd-current@freebsd.org Fri Feb 26 03:43:00 2021 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 23F48553B89 for ; Fri, 26 Feb 2021 03:43:00 +0000 (UTC) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4DmwTt6V4Zz4h9G; Fri, 26 Feb 2021 03:42:58 +0000 (UTC) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (localhost [127.0.0.1]) by gndrsh.dnsmgr.net (8.13.3/8.13.3) with ESMTP id 11Q3glEL028500; Thu, 25 Feb 2021 19:42:47 -0800 (PST) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: (from freebsd@localhost) by gndrsh.dnsmgr.net (8.13.3/8.13.3/Submit) id 11Q3gkZU028499; Thu, 25 Feb 2021 19:42:46 -0800 (PST) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <202102260342.11Q3gkZU028499@gndrsh.dnsmgr.net> Subject: Re: testers needed: loader: use display pixel density for font autoselection In-Reply-To: <30FE8DB4-19C4-4A7E-926C-A790562D09DC@me.com> To: Toomas Soome Date: Thu, 25 Feb 2021 19:42:46 -0800 (PST) CC: Jakob Alvermark , FreeBSD Developers , freebsd-current Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 4DmwTt6V4Zz4h9G X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of freebsd@gndrsh.dnsmgr.net has no SPF policy when checking 69.59.192.140) smtp.mailfrom=freebsd@gndrsh.dnsmgr.net X-Spamd-Result: default: False [-1.58 / 15.00]; HAS_REPLYTO(0.00)[rgrimes@freebsd.org]; ARC_NA(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; REPLYTO_DOM_NEQ_FROM_DOM(0.00)[]; DMARC_NA(0.00)[dnsmgr.net]; R_SPF_NA(0.00)[no SPF record]; SPAMHAUS_ZRD(0.00)[69.59.192.140:from:127.0.2.255]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; NEURAL_HAM_SHORT(-0.48)[-0.480]; AUTH_NA(1.00)[]; RCVD_TLS_LAST(0.00)[]; FREEMAIL_TO(0.00)[me.com]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:13868, ipnet:69.59.192.0/19, country:US]; RCVD_COUNT_TWO(0.00)[2]; MAILMAN_DEST(0.00)[freebsd-current]; RBL_DBL_DONT_QUERY_IPS(0.00)[69.59.192.140:from] X-Mailman-Approved-At: Fri, 26 Feb 2021 06:26:37 +0000 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Feb 2021 03:43:00 -0000 > > On 23. Feb 2021, at 17:53, Jakob Alvermark wrote: > > > > On 2/23/21 12:27 PM, Toomas Soome via freebsd-current wrote: > >> hi! > >> > >> I have done some work to make font pickup a bit smarter (hopefully better;), but my own ability to test is limited to one bugged supermicro and one MBP with retina display? > >> > >> The phab link ishttps://reviews.freebsd.org/D28849 > >> > >> I have built loader binaries as well (bios and uefi): > >> loader_lua > >> loader_lua.efi > >> > >> To test, you should remove screen.font= line from loader.conf and test with different resolutions. > >> > >> thanks, > >> toomas > > > > > > > > Hi Toomas, > > > > > > I tested on five different setups. > > > > Surface Pro 10.6"@1920x1080: > > > > The loader menu looks different, the "FreeBSD" text is on the right side of the screen. > > > I think, this was the lua script bug we did fix not too long time ago. > > > > > Otherwise, the font size is what I would call a normal size. > > > > > > Acer laptop 11.6"@1366x768: > > > > Menu looks fine. Almost fills the entire screen. > > > > The font feels a little too big. > > > The laptop built in displays usually do not give out EDID (we get physical dimensions from EDID), so there we fall back to try to get 80x25 terminal method. I am having a hard time with that statement. EDID is very common on laptop screens, infact I can not recall ever not seeing EDID on a laptops builtin screen. My 11" acer 1400 has EDID in it. > > > > Thinkpad built in 13"@1920x1080: > > > > Menu looks fine, but a little slow. > > > > The font size is a little to big for my liking. When drm loads and mirrors the screen to my external 27" it looks comically large. > > > > There is another issue - once DRM will kick in, we should re-consider the console attributes, like fonts, but at this time, the kernel itself only can use what was built in (8x16), or what loader was offering (default if present). So it is up to user to act there. It would be really nice if DRM could pick up what the resolution and font was when it loaded! > > > > > Thinkpad external 24"@1920x1200: > > > > Menu looks OK, uses about a quarter of the screen. > > > > Font size is fine, but once drm loads it looks a bit squeezed (like thin and tall), but I guess that's drm detecting the built in 1920x1080, and the external display is stretched. > > > > > > Thinkpad external 27"@3840x2160: > > > > Menu looks OK, uses about a quarter of the screen. > > > > Font size is fine. > > > > Looking at the dmesg though, it says: VT(efifb): resolution 1920x1080 > > > > > > Jakob > > > > > Those cases .. I suppose the menu was still at left side, not in middle? The thing there is, our menu is designed for 80x25 screen, with respective constants. SO again... why are we deviating from that causing us issues? > > many thanks for testing, I have downloaded your modified loader, and put it in place, it shall get tested on my next reboot, which should be soon as 13-BETA4 should be popping out soon. > toomas > > > -- Rod Grimes rgrimes@freebsd.org