From owner-svn-src-all@freebsd.org Thu Jul 2 19:20:57 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id A329035E226; Thu, 2 Jul 2020 19:20:57 +0000 (UTC) (envelope-from etnapierala@gmail.com) Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 49yScS4SzDz4D1g; Thu, 2 Jul 2020 19:20:56 +0000 (UTC) (envelope-from etnapierala@gmail.com) Received: by mail-wr1-x442.google.com with SMTP id f18so21714504wrs.0; Thu, 02 Jul 2020 12:20:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:mail-followup-to :references:mime-version:content-disposition:in-reply-to; bh=wXzAftCdCQa3wtM/e92v3o/hRyW5e6yhG3r/pT7PQ6E=; b=MTEEmNV+5sY8tX6MUyYKxsB5oEmpiQuiNW4OEqVsoPEBpQzVBOYiMS3KRQgzf1EvJK /lgx+SzgTmjyOA+VmoJQdjkRPhTNAS9vktG5gQMGLtJyDvR0YvXZqBiMiEV7ltID3p8A TVCJtHh/1a4AzaOdokCIk9Ylm7N1FMx/psY1K4oNzbWQglPQijbyRR+sVwF8oHkvH9oL YDRNGIjbJdfFlYmusz8QMSXWEU30yBwDLlLnKHOVZvVGEV2UUcUdFaB3hgiAaHxYR3he 9Bd9GQePaWB8sEZkJF2aKfKrsdZVjpZ0qRNcMbHZGABr/AKIK/EskFf1bNZKNcbWWf1l 2S3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=wXzAftCdCQa3wtM/e92v3o/hRyW5e6yhG3r/pT7PQ6E=; b=s5sdKl1z+6Shj3qBa4rN3B05q6xpZbAC8miXPm9reNVm7aeILXDBUM5+jOANsPUKaT 4DpHRvi45unrUfO+4D+klFdLymbNkjGkhby8ElvWz/UZaL89Buxw3yhNnFnjaZxgrQus Jt/hP9dKWj5Qo6gJtddG47H8TdCQi8YlvU52rZFANV8iUkPRVvAGmEc/Lucg/4KlbvYz CH/rpeEQTbEq7c68TqObm0esFLgPWl0gagfiLnRLVPxfx9M0GVlwJav6fTrM5NYTyBgX 6lX4iCz968gKQ9j/8CfBO7gnZI1pYFZqRk74E6Oooij1f5E6HCXeCr8ASL3Q1lNs0opz lfZA== X-Gm-Message-State: AOAM530G7bFdeCwDTb/3//qVZrqJfiek/7g8QOjA4Rhu1k5YTqXeWv+J Zt2baOeIaMd9y5yTcBjMaAaZro+c X-Google-Smtp-Source: ABdhPJyE1kEQolItVatHLBQ8dGZlWBBhGzOl5B0ROyuytl0ToXmKAxQXaaoaeaCd50hgHVYC5safuw== X-Received: by 2002:a5d:4903:: with SMTP id x3mr35073859wrq.351.1593717653059; Thu, 02 Jul 2020 12:20:53 -0700 (PDT) Received: from brick (cpc149474-cmbg20-2-0-cust954.5-4.cable.virginm.net. [82.4.199.187]) by smtp.gmail.com with ESMTPSA id z63sm6965995wmb.2.2020.07.02.12.20.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jul 2020 12:20:51 -0700 (PDT) Sender: =?UTF-8?Q?Edward_Tomasz_Napiera=C5=82a?= Date: Thu, 2 Jul 2020 20:20:49 +0100 From: Edward Tomasz =?utf-8?Q?Napiera=C5=82a?= To: Kyle Evans Cc: Shawn Webb , src-committers , svn-src-all , svn-src-head Subject: Re: svn commit: r362769 - in head/sys: amd64/linux amd64/linux32 arm64/linux compat/linux i386/linux Message-ID: <20200702192049.GA51788@brick> Mail-Followup-To: Kyle Evans , Shawn Webb , src-committers , svn-src-all , svn-src-head References: <202006290309.05T39ETZ044859@repo.freebsd.org> <20200629152717.2ojwnipxkmjaoix2@mutt-hbsd> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 49yScS4SzDz4D1g X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=MTEEmNV+; dmarc=none; spf=pass (mx1.freebsd.org: domain of etnapierala@gmail.com designates 2a00:1450:4864:20::442 as permitted sender) smtp.mailfrom=etnapierala@gmail.com X-Spamd-Result: default: False [-2.43 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; NEURAL_HAM_MEDIUM(-0.95)[-0.946]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1450:4000::/36]; NEURAL_HAM_LONG(-1.00)[-0.999]; MIME_GOOD(-0.10)[text/plain]; MID_RHS_NOT_FQDN(0.50)[]; DMARC_NA(0.00)[freebsd.org]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; NEURAL_HAM_SHORT(-0.78)[-0.782]; RCVD_IN_DNSWL_NONE(0.00)[2a00:1450:4864:20::442:from]; FORGED_SENDER(0.30)[trasz@freebsd.org,etnapierala@gmail.com]; RECEIVED_SPAMHAUS_PBL(0.00)[82.4.199.187:received]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[trasz@freebsd.org,etnapierala@gmail.com]; RCVD_TLS_ALL(0.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Jul 2020 19:20:57 -0000 On 0629T1242, Kyle Evans wrote: > On Mon, Jun 29, 2020 at 10:27 AM Shawn Webb wrote: > > > > Hey Kyle, > > > > On Mon, Jun 29, 2020 at 03:09:14AM +0000, Kyle Evans wrote: > > > Author: kevans > > > Date: Mon Jun 29 03:09:14 2020 > > > New Revision: 362769 > > > URL: https://svnweb.freebsd.org/changeset/base/362769 > > > > > > Log: > > > linuxolator: implement memfd_create syscall > > > > > > This effectively mirrors our libc implementation, but with minor fudging -- > > > name needs to be copied in from userspace, so we just copy it straight into > > > stack-allocated memfd_name into the correct position rather than allocating > > > memory that needs to be cleaned up. > > > > > > The sealing-related fcntl(2) commands, F_GET_SEALS and F_ADD_SEALS, have > > > also been implemented now that we support them. > > > > > > Note that this implementation is still not quite at feature parity w.r.t. > > > the actual Linux version; some caveats, from my foggy memory: > > > > > > - Need to implement SHM_GROW_ON_WRITE, default for memfd (in progress) > > > - LTP wants the memfd name exposed to fdescfs > > > - Linux allows open() of an fdescfs fd with O_TRUNC to truncate after dup. > > > (?) > > > > > > Interested parties can install and run LTP from ports (devel/linux-ltp) to > > > confirm any fixes. > > > > > > PR: 240874 > > > Reviewed by: kib, trasz > > > Differential Revision: https://reviews.freebsd.org/D21845 > > > > RELNOTES? > > > > > > > > Modified: > > > head/sys/amd64/linux/linux_dummy.c > > > head/sys/amd64/linux32/linux32_dummy.c > > > head/sys/arm64/linux/linux_dummy.c > > > head/sys/compat/linux/linux.c > > > head/sys/compat/linux/linux.h > > > head/sys/compat/linux/linux_file.c > > > head/sys/compat/linux/linux_file.h > > > head/sys/i386/linux/linux_dummy.c > > > > Should __FreeBSD_version be bumped? > > > > I'm roping in trasz@, because I'm unsure on either of these points -- > I haven't paid attention and don't know if we typically include linux > syscalls that we implement in relnotes, and given that this commit > only really affects pre-compiled Linux binaries I'm not sure if > there's any utility in bumping __FreeBSD_version; presumably ports > folks can't do anything differently here, and binaries will work just > the same. I don't think we need to bump the version here. As for the relnotes: I hadn't considered that before, but it sounds like a good idea; we probably do want to at least enumerate the major Linuxulator changes there.